Closed Bug 1243133 Opened 9 years ago Closed 9 years ago

Fix brace-style warnings in webconsole.js

Categories

(DevTools :: Console, defect)

Product:
DevTools
Component:
Console
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox47 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 47
Tracking Flags:
Tracking Status
firefox47 --- fixed

People

(Reporter: ajkerrigan, Assigned: ajkerrigan)

References

Details

(Whiteboard: [lang=js])

Attachments

(1 file)

MozReview Request: Bug 1243133 - Fix brace style in webconsole.js; r?linclark
58 bytes, text/x-review-board-request
linclark
: review+
Details
ESLint throws close to 500 warnings and errors for webconsole.js. 195 of these concern brace style.
I'd like to take and work on this. Lin, would you mind having a look at this and assigning me if you're OK with that?
Depends on: 1232731
Flags: needinfo?(lclark)
Whiteboard: [lang=js]
Awesome! I've assigned it to you.
Assignee: nobody → ajkerrigan
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(lclark)
Blocks: 1232731
No longer depends on: 1232731
Attachment #8712518 - Flags: review?(bgrinstead)
Comment on attachment 8712518 [details] MozReview Request: Bug 1243133 - Fix brace style in webconsole.js; r?linclark Redirecting to Lin (mozreview doesn't set her as the reviewer correctly for some reason).
Attachment #8712518 - Flags: review?(bgrinstead) → review?(lclark)
Attachment #8712518 - Flags: review?(lclark) → review+
Comment on attachment 8712518 [details] MozReview Request: Bug 1243133 - Fix brace style in webconsole.js; r?linclark https://reviewboard.mozilla.org/r/32569/#review29403 Looks good to me! Thanks for the patch :)
https://hg.mozilla.org/mozilla-central/rev/e8996738efd8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: