Fix brace-style warnings in webconsole.js

RESOLVED FIXED in Firefox 47

Status

()

Firefox
Developer Tools: Console
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ajkerrigan, Assigned: ajkerrigan)

Tracking

Trunk
Firefox 47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

(Whiteboard: [lang=js])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
ESLint throws close to 500 warnings and errors for webconsole.js. 195 of these concern brace style.
(Assignee)

Comment 1

2 years ago
I'd like to take and work on this. Lin, would you mind having a look at this and assigning me if you're OK with that?
Depends on: 1232731
Flags: needinfo?(lclark)
Whiteboard: [lang=js]
Awesome! I've assigned it to you.
Assignee: nobody → ajkerrigan
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(lclark)
(Assignee)

Updated

2 years ago
Blocks: 1232731
No longer depends on: 1232731
(Assignee)

Comment 3

2 years ago
Created attachment 8712518 [details]
MozReview Request: Bug 1243133 - Fix brace style in webconsole.js; r?linclark

Get rid of ESLint brace style warnings by converting to 1TBS.

Review commit: https://reviewboard.mozilla.org/r/32569/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32569/
(Assignee)

Updated

2 years ago
Attachment #8712518 - Flags: review?(bgrinstead)
Comment on attachment 8712518 [details]
MozReview Request: Bug 1243133 - Fix brace style in webconsole.js; r?linclark

Redirecting to Lin (mozreview doesn't set her as the reviewer correctly for some reason).
Attachment #8712518 - Flags: review?(bgrinstead) → review?(lclark)

Updated

2 years ago
Attachment #8712518 - Flags: review?(lclark) → review+
Comment on attachment 8712518 [details]
MozReview Request: Bug 1243133 - Fix brace style in webconsole.js; r?linclark

https://reviewboard.mozilla.org/r/32569/#review29403

Looks good to me! Thanks for the patch :)

Updated

2 years ago
Keywords: checkin-needed

Comment 6

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/e8996738efd8
Keywords: checkin-needed

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e8996738efd8
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.