1232731 - [META] Fix code style in webconsole.js

Status: RESOLVED WONTFIX

(DevTools :: Console, defect)

Description

[Lin Clark [:linclark]]

There are lots of ESLint warnings and aVariable style parameters in webconsole.js.

Comment 1

[Lin Clark [:linclark]]

Turns out there are a *ton* of different rule breakages in this file, so turning this into a meta issue.

Comment 2

[Lin Clark [:linclark]]

Thanks everyone! We are so very close!

Now that Bug 1256163 landed, I checked origin/fx-team. It looks like 1 more error snuck in there :( I'm now thinking the best way to avoid this is to add ignores for each .js file or directory at the top level in the webconsole directory. This should only require adding a handful of lines to the file.

Comment 3

[ewhite7]

I'm a student at Seneca college learning open source, and I was hoping to work on this bug for my course.  If no one else is currently working on it, I'd like to give it a try even though i am not familiar with linting

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to ewhite7 from comment #3)
> I'm a student at Seneca college learning open source, and I was hoping to
> work on this bug for my course.  If no one else is currently working on it,
> I'd like to give it a try even though i am not familiar with linting

Hi, fixing lint on webconsole.js isn't needed anymore with the new console frontend that we've been working on, so I'm going to close this bug. But there should be another bug you could take.  Would you like to try https://bugzilla.mozilla.org/show_bug.cgi?id=1393609?  I'll add some more instructions on how to start in that bug.