Closed Bug 1243154 Opened 8 years ago Closed 8 years ago

Logins list shows "No logins found" for 5+ seconds with 600+ logins

Categories

(Firefox for iOS :: Data Storage, defect)

Product:
Firefox for iOS
Component:
Data Storage
Platform:
All
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios 2.0+ ---

People

(Reporter: MattN, Assigned: sleroux)

References

Details

(Keywords: perf)

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1492
48 bytes, text/x-github-pull-request
rnewman
: review+
Details | Review 
STR:
1) Open Settings > Logins

Expected result:
Some logins appear within a second or so.

Actual result:
"No logins found" appears for 5-6 seconds then logins appear.
See Also: → 1243156
Hooray databases! :D

We should do some or all of:

* Make our queries faster. We haven't spent a lot of time measuring, assessing index cost/benefits, etc.
* Not fetching everything at once. This is a sorted list, so paging it in in chunks shouldn't be impossible.
* Showing a spinner.
tracking-fxios: --- → ?
Flags: needinfo?(sleroux)
Sorry Richard but I figured you'd probably be the best person to review this.
Flags: needinfo?(sleroux)
Attachment #8714969 - Flags: review?(rnewman)
Assignee: nobody → sleroux
Status: NEW → ASSIGNED
Attachment #8714969 - Flags: review?(rnewman) → review+
Component: General → Data Storage
Keywords: perf
Hardware: Other → All
master 5865e3c5750750b468305957c971c4bfb2e36e47
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
tracking-fxios: ? → 2.0+
Target Milestone: --- → 2.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: