1243156 - Logins list scrolling is horribly janky with 600+ logins

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Matthew N. [:MattN]]

STR:
1) Open Settings > Logins when you have hundreds of logins e.g. 600

Expected result:
Once logins appear, scrolling should be smooth

Actual result:
Scrolling is horribly janky and slow. I get about 2-3 frames per second scrolling.

Comment 1

[Stephan Leroux [:sleroux]]

Looks like inside the loginAtIndexPath the act of calling sectionIndexTitles is very expensive because it needs to calculate the publicSuffix of each URL which looks to be not cheap. See attached profile snapshot of behaviour while scrolling.

Comment 2

[Stephan Leroux [:sleroux]]

Attachment: Screenshot 2016-02-02 16.38.45.png

Comment 3

[Richard Newman [:rnewman]]

Can we just precompute the domain, either in SQL or in the cursor factory?

Comment 4

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1525

Comment 5

[Brian Nicholson (:bnicholson)]

Comment on attachment 8718442 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1525

Looks great!

Comment 6

[Stephan Leroux [:sleroux]]

master b499bb258672f3b5350d841d9b95ba029498496d