Closed Bug 1243216 Opened 4 years ago Closed 4 years ago

Make clickable slides more visible

Categories

(Firefox for Android :: First Run, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 47
Tracking Status
firefox46 --- fixed
firefox47 --- fixed
fennec 46+ ---

People

(Reporter: liuche, Assigned: liuche)

References

Details

Attachments

(4 files)

We include a slide that is clickable to set a pref, but there is not much of a hint that the slide is clickable.

We could do the following:
* Move the slider outside of the image so it stands out
* Also add another slider to the first slide, to introduce it early ("turn on search suggestions") and add copy to explain the pref

Anthony, we talked about this briefly, so over to you for changes to this idea or mocks or more specific details!
tracking-fennec: --- → ?
Flags: needinfo?(alam)
tracking-fennec: ? → 46+
Specifically, I think this involves changing our illustrations. I'll try to keep them the same size so we don't have to worry about too much.

Since we aren't using SVG just yet, and I'm experiencing some weirdness with SVG that I have to look into, Try these .PNG!

The only "switches" we currently have are for the "show images" pref so here they are.
Flags: needinfo?(alam) → needinfo?(liuche)
Looking at UI Telemetry, we have a probe for the clickable data panel, but zero people have clicked it so far.

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/firstrun/DataPanel.java#41

Let's do more to make it _very_ obvious to people that they can use tap a widget to enable data savings.
Flags: needinfo?(margaret.leibovic)
This bug is tracking 46+. If it's as simple as an image swap, let's try landing a patch and see what happens.
Assignee: nobody → liuche
Flags: needinfo?(margaret.leibovic)
(In reply to :Margaret Leibovic from comment #3)
> This bug is tracking 46+. If it's as simple as an image swap, let's try
> landing a patch and see what happens.

If we can't get the images in for 46, I also have updated copy from Matej that I'd like to add to this design - It helps complete the messaging.

Body: "Turn off images to spend less data on every site you visit.”

If not, we can split it up into another bug.

(In reply to Mark Finkle (:mfinkle) from comment #2)
> Looking at UI Telemetry, we have a probe for the clickable data panel, but
> zero people have clicked it so far.
> 
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/
> mozilla/gecko/firstrun/DataPanel.java#41
> 
> Let's do more to make it _very_ obvious to people that they can use tap a
> widget to enable data savings.

I also want to do more to ensure this is obvious for our users. I think bug 1245934 will really help with that too given that it's the first slide - it will help set up expectations.
Blocks: 1238780
No longer depends on: 1238780
Comment on attachment 8720091 [details]
MozReview Request: Bug 1243216 - Make clickable slides more visible. r=margaret

https://reviewboard.mozilla.org/r/35205/#review31967
Attachment #8720091 - Flags: review?(margaret.leibovic) → review+
(Make sure you pngcrush the new image)
Flags: needinfo?(liuche)
https://hg.mozilla.org/mozilla-central/rev/0e8af856a2d4
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
(In reply to :Margaret Leibovic from comment #7)
> (Make sure you pngcrush the new image)

I noticed a small (74KB) bump in APK size due to this image. I assume that pngcrush was used, and pngquant was attempted. pngcrush reduces the size of most images, but pngquant does a much better job. The problem with pngquant is dithering artifacts can be introduced. So should we use pngcrush all the time and try pngquant, but verify the image still looks very good.
I used ImageOptim, which looks like it tries pngcrush along with a bunch of other image compressing libraries/apps. It doesn't look like pngquant is one of the options, so I gave it a try - it looks like it makes the images even smaller, down to 19KB (vs 39KB or 47KB), without any visual problems. I'll make a patch and attach it to this bug.

https://imageoptim.com/
Attachment #8721120 - Flags: review?(mark.finkle)
Comment on attachment 8721120 [details] [diff] [review]
Patch: pngquant images

Review of attachment 8721120 [details] [diff] [review]:
-----------------------------------------------------------------

Zoink!

It would be good to make a post to mobile-firefox-dev about best practices for crushing images. Maybe also add that to the wiki somewhere (if it isn't there already).
Attachment #8721120 - Flags: review?(mark.finkle) → review+
Mentioning something Richard pointed out about pngquant: We need to verify that hi-dpi devices are not showing any dithering or banding on the images. You can try this in local builds, but be sure to use a hi-dpi test device.

Be on the lookout!
Approval Request Comment
[Feature/regressing bug #]: Bug 1238780 added new slides, but telemetry shows that the images are too hidden.
[User impact if declined]: Users will have less obvious hints to click on a first run button
[Describe test coverage new/current, TreeHerder]: In nightly
[Risks and why]: very low, replace two image files
[String/UUID change made/needed]: none
Attachment #8724318 - Flags: review+
Attachment #8724318 - Flags: approval-mozilla-aurora?
Comment on attachment 8724318 [details] [diff] [review]
Aurora patch: Switch to clickable images

Minor ui tweak, please uplift to aurora.
Attachment #8724318 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.