Closed Bug 1243412 Opened 10 years ago Closed 9 years ago

Rework top-site edit mode; allow contextual press on top-sites (open in new tab/private tab/remove)

Categories

(Firefox for iOS :: General, enhancement, P1)

Product:
Firefox for iOS
Component:
General
Platform:
All
iOS
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Iteration:
1.8
Tracking Flags:
Tracking Status
fxios + ---

People

(Reporter: aaronmt, Assigned: maurya1985)

References

Details

(Whiteboard: [MobileAS])

Attachments

(2 files, 5 obsolete files)

Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2177
55 bytes, text/x-github-pull-request
farhan
: review+
Details | Review
Pull Request
55 bytes, text/x-github-pull-request
sleroux
: review+
Details | Review
We should rework the top-sites 'edit' mode feature by removing it's current mode of entry and instead simply allow contextual press on a thumbnail top-site and offer: * 'Open in new tab' (background tab) * 'Open in private tab' (background tab) * 'Remove' Eliminates the backtracking back to about:home to open many sites at once. Eliminates the complication with 'Edit mode'.
Severity: normal → enhancement
This'd fix the root cause of Bug 1178350, which would be nice.
Hardware: Other → All
Great suggestion. Needs some UX work for the dialog presentation but seems like a quick win.
Currently 'edit mode' seems to cause issues like bug 1254269.
Assignee: nobody → maurya1985
Status: NEW → ASSIGNED
Comment on attachment 8793316 [details] [review] Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/2106 I've left some feedback on the PR!
Attachment #8793316 - Flags: review?(fpatel)
Depends on: 1297128
Attachment #8799292 - Flags: review?(fpatel)
Attachment #8799292 - Flags: review?(fpatel) → review-
Blocks: 1159439
Attachment #8799292 - Attachment is obsolete: true
Attachment #8801473 - Flags: review?(fpatel)
Comment on attachment 8801473 [details] [review] Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2177 Almost there! Thanks for addressing all the issues!
Attachment #8801473 - Flags: review?(fpatel) → review-
QA Contact: aaron.train
Marking as [MobileAS] and added to UI user story for Activity Stream.
Blocks: 1311083
No longer blocks: 1159439
Priority: -- → P2
Whiteboard: [MobileAS]
Attachment #8801473 - Attachment description: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2106 → Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2177
Attachment #8801473 - Attachment is obsolete: true
review ping
Flags: needinfo?(fpatel)
Great work. I've left some comments. Just stylistic changes now :)
Flags: needinfo?(fpatel)
Attachment #8804166 - Attachment is obsolete: true
Attachment #8804166 - Flags: review?(fpatel)
Attachment #8805797 - Flags: review?(fpatel)
Attachment #8805797 - Flags: review?(fpatel) → review-
Attachment #8806324 - Flags: review?(fpatel) → review+
Attached file Pull Request —
I just cleaned up some stuff related to ASPing, Context Menu and AS in general. Mainly renaming and moving stuff around.
Attachment #8806620 - Flags: review?(sleroux)
Comment on attachment 8806620 [details] [review] Pull Request Nice clean up =)
Attachment #8806620 - Flags: review?(sleroux) → review+
master https://github.com/mozilla-mobile/firefox-ios/commit/5c9913a87b0652729e0f29a58f72ab145077b23a
Status: ASSIGNED → RESOLVED
Iteration: --- → 1.8
Closed: 9 years ago
Priority: P2 → P1
Resolution: --- → FIXED
Blocks: 1314398
Blocks: 1314687
No longer blocks: 1314398
Blocks: 1314369
No longer blocks: 1314687
Blocks: 1314371
Depends on: 1318715
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: