Rework top-site edit mode; allow contextual press on top-sites (open in new tab/private tab/remove)

RESOLVED FIXED

Status

()

Firefox for iOS
General
P1
enhancement
RESOLVED FIXED
2 years ago
11 months ago

People

(Reporter: aaronmt, Assigned: Maurya Talisetti)

Tracking

unspecified
All
iOS
Dependency tree / graph

Firefox Tracking Flags

(fxios+)

Details

(Whiteboard: [MobileAS])

Attachments

(2 attachments, 5 obsolete attachments)

(Reporter)

Description

2 years ago
We should rework the top-sites 'edit' mode feature by removing it's current mode of entry and instead simply allow contextual press on a thumbnail top-site and offer:

* 'Open in new tab' (background tab)
* 'Open in private tab' (background tab)
* 'Remove'

Eliminates the backtracking back to about:home to open many sites at once. Eliminates the complication with 'Edit mode'.
(Reporter)

Updated

2 years ago
Severity: normal → enhancement
This'd fix the root cause of Bug 1178350, which would be nice.
Hardware: Other → All
Great suggestion. Needs some UX work for the dialog presentation but seems like a quick win.
tracking-fxios: ? → +
(Reporter)

Comment 3

2 years ago
Currently 'edit mode' seems to cause issues like bug 1254269.
(Assignee)

Updated

a year ago
Assignee: nobody → maurya1985
(Assignee)

Updated

a year ago
Status: NEW → ASSIGNED
(Assignee)

Comment 4

a year ago
Created attachment 8793316 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/2106
Attachment #8793316 - Flags: review?(fpatel)
Comment on attachment 8793316 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/2106

I've left some feedback on the PR!
Attachment #8793316 - Flags: review?(fpatel)
(Assignee)

Updated

a year ago
Depends on: 1297128
(Assignee)

Comment 6

a year ago
Created attachment 8799292 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2106
Attachment #8793316 - Attachment is obsolete: true
(Assignee)

Updated

a year ago
Attachment #8799292 - Flags: review?(fpatel)
Attachment #8799292 - Flags: review?(fpatel) → review-
(Assignee)

Updated

a year ago
Blocks: 1159439
(Assignee)

Comment 7

a year ago
Created attachment 8801473 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2177
Attachment #8799292 - Attachment is obsolete: true
Attachment #8801473 - Flags: review?(fpatel)
Comment on attachment 8801473 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2177

Almost there! Thanks for addressing all the issues!
Attachment #8801473 - Flags: review?(fpatel) → review-
(Reporter)

Updated

a year ago
QA Contact: aaron.train
Marking as [MobileAS] and added to UI user story for Activity Stream.
Blocks: 1311083
No longer blocks: 1159439
Priority: -- → P2
Whiteboard: [MobileAS]
(Assignee)

Comment 10

a year ago
Created attachment 8804166 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2177
Attachment #8804166 - Flags: review?(fpatel)
(Assignee)

Updated

a year ago
Attachment #8801473 - Attachment description: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2106 → Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2177
Attachment #8801473 - Attachment is obsolete: true
(Assignee)

Comment 11

a year ago
review ping
Flags: needinfo?(fpatel)
Great work. I've left some comments. Just stylistic changes now :)
Flags: needinfo?(fpatel)
(Assignee)

Comment 13

a year ago
Created attachment 8805797 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2177
Attachment #8804166 - Attachment is obsolete: true
Attachment #8804166 - Flags: review?(fpatel)
Attachment #8805797 - Flags: review?(fpatel)
Attachment #8805797 - Flags: review?(fpatel) → review-
(Assignee)

Comment 14

a year ago
Created attachment 8806324 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2177
Attachment #8805797 - Attachment is obsolete: true
Attachment #8806324 - Flags: review?(fpatel)
Attachment #8806324 - Flags: review?(fpatel) → review+
master https://github.com/mozilla-mobile/firefox-ios/commit/0da9bd79a8efda8c57c49f724ebcf381379733a0
Created attachment 8806620 [details] [review]
Pull Request

I just cleaned up some stuff related to ASPing, Context Menu and AS in general. Mainly renaming and moving stuff around.
Attachment #8806620 - Flags: review?(sleroux)
Comment on attachment 8806620 [details] [review]
Pull Request

Nice clean up =)
Attachment #8806620 - Flags: review?(sleroux) → review+
master https://github.com/mozilla-mobile/firefox-ios/commit/5c9913a87b0652729e0f29a58f72ab145077b23a
Status: ASSIGNED → RESOLVED
Iteration: --- → 1.8
Last Resolved: a year ago
Priority: P2 → P1
Resolution: --- → FIXED

Updated

11 months ago
Blocks: 1314398

Updated

11 months ago
Blocks: 1314687

Updated

11 months ago
No longer blocks: 1314398

Updated

11 months ago
Blocks: 1314369

Updated

11 months ago
No longer blocks: 1314687

Updated

11 months ago
Blocks: 1314371
(Reporter)

Updated

11 months ago
Depends on: 1318715
You need to log in before you can comment on or make changes to this bug.