1243607 - Re-enable webrtc bandwidth prefs (to override adaptive bandwidth settings)

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Randell Jesup [:jesup] (needinfo me)]

When we landed code to adapt bitrates according to resolution, that effectively disabled the bitrate prefs in about:config.

We need to be able to set bitrates for testing simulcast, since if the measured bitrate is too low, no bits will be available for the upper encodings.  It also restores the ability to override automatic bitrates for testing and other reasons, and should improve repeatibility of tests.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: MozReview Request: Bug 1243607: make webrtc bitrate prefs take precedence over automatic bitrate selection r?pkerr

Review commit: https://reviewboard.mozilla.org/r/32727/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32727/

Comment 2

[Paul Kerr [:pkerr]]

Comment on attachment 8712975 [details]
MozReview Request: Bug 1243607: make webrtc bitrate prefs take precedence over automatic bitrate selection r?pkerr

https://reviewboard.mozilla.org/r/32727/#review29537

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ebf10602138c

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5d8f454c269e

Comment 5

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cba3384cdcd92f59ed54f3ac08766fef99b8263d
Backed out changeset 5d8f454c269e (bug 1243607) for test_peerConnection_verifyVideoAfterRenegotiation.html timeout

https://hg.mozilla.org/integration/mozilla-inbound/rev/641572c3f147410c92c167b9ed0ea8251be1e488
Backed out changeset ebf10602138c (bug 1243607) for test_peerConnection_verifyVideoAfterRenegotiation.html timeout

Comment 6

[Nigel Babu [:nigelb]]

Had to back it out because the followup commit did not fix the issue on (at least) Win7

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Add lower-limit WebRTC bandwidth pref for testing

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Update simulcast test to lower-limit bandwidth

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ecdda5be9858

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ecdda5be9858

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8712975 [details]
MozReview Request: Bug 1243607: make webrtc bitrate prefs take precedence over automatic bitrate selection r?pkerr

Approval Request Comment
[Feature/regressing bug #]: Adding simulcast tests; see bug 1242199

[User impact if declined]: WIll need to disable simulcast tests in Aurora

[Describe test coverage new/current, TreeHerder]: This avoids the test being turned off

[Risks and why]: Very low risk - pref to override internal bandwidth estimates

[String/UUID change made/needed]: None

This request applies to all patches here, including the one that landed with bug 1242199 in the summary (middle of these 3)

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8712975 [details]
MozReview Request: Bug 1243607: make webrtc bitrate prefs take precedence over automatic bitrate selection r?pkerr

Approved for uplift as this will allow for better test coverage for webrtc.
All 3 patches please.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/672aef86e497

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I needed to back this out from Aurora because it caused a very frequent intermittent failure in test_peerConnection_verifyVideoAfterRenegotiation.html:
https://treeherder.mozilla.org/logviewer.html#?job_id=1892471&repo=mozilla-aurora

https://hg.mozilla.org/releases/mozilla-aurora/rev/fdd161e60e46

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

From the looks of things, not all of the patches got uplifted.

Comment 16

[Carsten Book [:Tomcat]]

liz, so uplifting bug 1242199  too is ok or ?

Comment 17

[Randell Jesup [:jesup] (needinfo me)]

(In reply to Carsten Book [:Tomcat] from comment #16)
> liz, so uplifting bug 1242199  too is ok or ?

Note the uplift request:
This request applies to all patches here, including the one that landed with bug 1242199 in the summary (middle of these 3)

Comment 18

[Carsten Book [:Tomcat]]

landed on aurora

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/a353c3674dd7
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/721ff777d29c