Re-enable webrtc bandwidth prefs (to override adaptive bandwidth settings)

RESOLVED FIXED in Firefox 46

Status

()

Core
WebRTC: Audio/Video
P1
normal
Rank:
10
RESOLVED FIXED
2 years ago
11 months ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

Trunk
mozilla47
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox45 wontfix, firefox46 fixed, firefox47 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Assignee)

Description

2 years ago
When we landed code to adapt bitrates according to resolution, that effectively disabled the bitrate prefs in about:config.

We need to be able to set bitrates for testing simulcast, since if the measured bitrate is too low, no bits will be available for the upper encodings.  It also restores the ability to override automatic bitrates for testing and other reasons, and should improve repeatibility of tests.
(Assignee)

Comment 1

2 years ago
Created attachment 8712975 [details]
MozReview Request: Bug 1243607: make webrtc bitrate prefs take precedence over automatic bitrate selection r?pkerr

Review commit: https://reviewboard.mozilla.org/r/32727/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32727/
Attachment #8712975 - Flags: review?(pkerr)
(Assignee)

Updated

2 years ago
backlog: --- → webrtc/webaudio+
Rank: 10
Priority: -- → P1

Comment 2

2 years ago
Comment on attachment 8712975 [details]
MozReview Request: Bug 1243607: make webrtc bitrate prefs take precedence over automatic bitrate selection r?pkerr

https://reviewboard.mozilla.org/r/32727/#review29537
Attachment #8712975 - Flags: review?(pkerr) → review+

Comment 5

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/cba3384cdcd92f59ed54f3ac08766fef99b8263d
Backed out changeset 5d8f454c269e (bug 1243607) for test_peerConnection_verifyVideoAfterRenegotiation.html timeout

https://hg.mozilla.org/integration/mozilla-inbound/rev/641572c3f147410c92c167b9ed0ea8251be1e488
Backed out changeset ebf10602138c (bug 1243607) for test_peerConnection_verifyVideoAfterRenegotiation.html timeout

Comment 6

2 years ago
Had to back it out because the followup commit did not fix the issue on (at least) Win7
(Assignee)

Comment 7

2 years ago
Created attachment 8713425 [details] [diff] [review]
Add lower-limit WebRTC bandwidth pref for testing
Attachment #8713425 - Flags: review?(pkerr)
(Assignee)

Comment 8

2 years ago
Created attachment 8713427 [details] [diff] [review]
Update simulcast test to lower-limit bandwidth
Attachment #8713427 - Flags: review?(pkerr)

Updated

2 years ago
Attachment #8713425 - Flags: review?(pkerr) → review+

Updated

2 years ago
Attachment #8713427 - Flags: review?(pkerr) → review+
(Assignee)

Updated

2 years ago
status-firefox45: --- → wontfix
status-firefox46: --- → affected

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ecdda5be9858
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
(Assignee)

Comment 11

2 years ago
Comment on attachment 8712975 [details]
MozReview Request: Bug 1243607: make webrtc bitrate prefs take precedence over automatic bitrate selection r?pkerr

Approval Request Comment
[Feature/regressing bug #]: Adding simulcast tests; see bug 1242199

[User impact if declined]: WIll need to disable simulcast tests in Aurora

[Describe test coverage new/current, TreeHerder]: This avoids the test being turned off

[Risks and why]: Very low risk - pref to override internal bandwidth estimates

[String/UUID change made/needed]: None

This request applies to all patches here, including the one that landed with bug 1242199 in the summary (middle of these 3)
Attachment #8712975 - Flags: approval-mozilla-aurora?
Comment on attachment 8712975 [details]
MozReview Request: Bug 1243607: make webrtc bitrate prefs take precedence over automatic bitrate selection r?pkerr

Approved for uplift as this will allow for better test coverage for webrtc.
All 3 patches please.
Attachment #8712975 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 13

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/672aef86e497
status-firefox46: affected → fixed
I needed to back this out from Aurora because it caused a very frequent intermittent failure in test_peerConnection_verifyVideoAfterRenegotiation.html:
https://treeherder.mozilla.org/logviewer.html#?job_id=1892471&repo=mozilla-aurora

https://hg.mozilla.org/releases/mozilla-aurora/rev/fdd161e60e46
status-firefox46: fixed → affected
Flags: needinfo?(rjesup)
From the looks of things, not all of the patches got uplifted.
liz, so uplifting bug 1242199  too is ok or ?
Flags: needinfo?(lhenry)
(Assignee)

Comment 17

2 years ago
(In reply to Carsten Book [:Tomcat] from comment #16)
> liz, so uplifting bug 1242199  too is ok or ?

Note the uplift request:
This request applies to all patches here, including the one that landed with bug 1242199 in the summary (middle of these 3)
Flags: needinfo?(rjesup)
landed on aurora

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/a353c3674dd7
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/721ff777d29c
status-firefox46: affected → fixed
Flags: needinfo?(lhenry)
(Assignee)

Updated

11 months ago
Duplicate of this bug: 1245263
You need to log in before you can comment on or make changes to this bug.