User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:47.0) Gecko/20100101 Firefox/47.0 Build ID: 20160127030236 Steps to reproduce: Updated to 47.0a1 (2016-01-27) Right click on image file Select "Save Image As..." in context menu Choose save directory and click save Actual results: Save dialog closes but file is not downloaded and no indication that download was started No issues with "Save Page As..." or "Save Video As..." or "Save Snapshot As..." I tried again with a new profile and the issue was not resolved. The issue does not occur in 44.0. Expected results: Indication that download has started
[Tracking Requested - why for this release]: Pushlog: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=59c5826c1280c0568705b04842e34815da52d6d2&tochange=9bf3cfaeeedc5896c590575eeb8aa57ed530a7fe Regressed by: Bug 1233497 Error on Brouser Console: unsafe CPOW usage forbidden contentAreaUtils.js:404:0
Thanks for filing, Sahil, and thanks for connecting me, Alice0775.
Created attachment 8713346 [details] [diff] [review] Deprecate unsafe CPOW usage in contentAreaUtils' saveImage
Created attachment 8713349 [details] [diff] [review] Don't pass unsafe CPOWs to saveImageURL when offering to save media to disk
Comment on attachment 8713349 [details] [diff] [review] Don't pass unsafe CPOWs to saveImageURL when offering to save media to disk Is this sort of stuff still swapped into your brain, jld? Or should I redirect?
Comment on attachment 8713346 [details] [diff] [review] Deprecate unsafe CPOW usage in contentAreaUtils' saveImage Review of attachment 8713346 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, and thanks for adding that function comment.
Aside: if there's a meta-bug for improving our test frameworks to make it easier to write automated regression tests for things like this, it'd be worth cross-referencing this bug.
It gets tricky, since our mochitests inherit the add-on shims. I will file a bug about seeing if we can start turning that off test by test. Thanks for the idea.
Actually, come to think of it, a test that exercises the image saving case should have caught this, since the unsafe CPOW access occurred asynchronously inside internalSave. I've filed bug 1244260 to get a test for this written.
https://hg.mozilla.org/integration/fx-team/rev/eb1acf2e2d72f120874f8d624d54e34d8a7ddeec Bug 1243643 - Deprecate unsafe CPOW usage in contentAreaUtils' saveImage. r=jld https://hg.mozilla.org/integration/fx-team/rev/7ae2adc4bb4400d9f6bf52eee2b046c3644c8776 Bug 1243643 - Don't pass unsafe CPOWs to saveImageURL when offering to save media to disk. r=jld
I have reproduced this bug on Nightly 47.0a1 (2016-01-27) on ubuntu 14.04 LTS, 32 bit! The bug's fix is now verified on Latest Nightly 47.0a1! Build ID: 20160203030249 User Agent: Mozilla/5.0 (X11; Linux i686; rv:47.0) Gecko/20100101 Firefox/47.0
Is this still an m8 blocker? Should this uplift to 46? Thanks.
I think we're still okay here - what broke this was CPOW outlawing, which landed in bug 1233497 in 47. 46 shouldn't be affected.
I managed to reproduce this bug on an affected build, i.e. 47.a1 (2016-01-27) using Windows 10 x64. This bug is confirmed fixed on 47.0b.3. [testday-20160506]
Updating this bug's status based on Comment 20.