Closed Bug 1243706 Opened 5 years ago Closed 5 years ago

Let PerfMonitoring ride the trains

Categories

(Toolkit :: Performance Monitoring, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed
relnote-firefox --- 47+

People

(Reporter: Yoric, Assigned: Yoric)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

Let's release the API. We can work on the UX later.
Attachment #8716192 - Flags: review?(felipc) → review+
Comment on attachment 8716192 [details]
MozReview Request: Bug 1243706 - Release PerformanceStats/PerformanceWatcher;r?felipe

https://reviewboard.mozilla.org/r/33401/#review30609

May be worth adding relnote to the bug? Does this need an intent to ship e-mail? I'm guessing no because it isn't exposed to the web

::: browser/components/nsBrowserGlue.js:545
(Diff revision 1)
>      if (AppConstants.NIGHTLY_BUILD) {
> -      AddonWatcher.init();
>        os.addObserver(this, AddonWatcher.TOPIC_SLOW_ADDON_DETECTED, false);
>      }

shouldn't this entire `if (NIGHLTY_BUILD)` block be removed as well?
https://reviewboard.mozilla.org/r/33401/#review30609

I don't think we need an intent to ship, but yes, relnotes is a good idea.

> shouldn't this entire `if (NIGHLTY_BUILD)` block be removed as well?

Actually, the idea is to ship without the annoying yellow bar. That one will only ship when UX has turned it into something usable.
Assignee: nobody → dteller
Release Note Request (optional, but appreciated)
[Why is this notable]: People have been asking for something like about:performance for years.
[Suggested wording]: Power users can now open about:performance to find out what is slowing down their Firefox. The underlying API is open to add-on developers who wish to implement their own performance tracking mechanism.
[Links (documentation, blog post, etc)]: TBD
relnote-firefox: --- → ?
Comment on attachment 8716192 [details]
MozReview Request: Bug 1243706 - Release PerformanceStats/PerformanceWatcher;r?felipe

I sent this to Try on top of m-c tip along with the Trunk-as-Aurora simulation patch and the browser-chrome mochitests look angry.

https://treeherder.mozilla.org/logviewer.html#?job_id=16616307&repo=try

TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_339445.js | A promise chain failed to handle a rejection: - at resource://gre/modules/XPCOMUtils.jsm:230 - TypeError: Cc[aContract] is undefined
TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_354894_perwindowpb.js | A promise chain failed to handle a rejection: - at resource://gre/modules/AddonWatcher.jsm:74 - ReferenceError: PerformanceWatcher is not defined 

etc.
Attachment #8716192 - Flags: feedback-
Comment on attachment 8716192 [details]
MozReview Request: Bug 1243706 - Release PerformanceStats/PerformanceWatcher;r?felipe

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33401/diff/1-2/
Attachment #8716192 - Flags: feedback-
Ok, found the issue.
Ryan, do you wish to re-run the Aurora simulation?
Flags: needinfo?(ryanvm)
https://hg.mozilla.org/mozilla-central/rev/02b9f8313561
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
(In reply to David Rajchenbach-Teller [:Yoric] (please use "needinfo") from comment #7)
> Ok, found the issue.
> Ryan, do you wish to re-run the Aurora simulation?

Still broken.
https://treeherder.mozilla.org/logviewer.html#?job_id=16844709&repo=try
Flags: needinfo?(ryanvm) → needinfo?(dteller)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #10)

This was taken care of in bug 1246277.
Flags: needinfo?(dteller)
You need to log in before you can comment on or make changes to this bug.