1278633 - about:performance not working in Seamonkey

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Frank-Rainer Grahl (:frg)]

Performance monitoring is a new feature in Firefox 47 but not working in Seamonkey 2.44

You get a 

>> Timestamp: 07.06.2016 20:03:29
>> Error: ReferenceError: performanceStatsService is not defined
>> Source File: resource://gre/modules/PerformanceStats.jsm
>> Line: 219

when you try it but it works fine in 2.47 c-c. Bug 1243706 got it into the release channel and we just need to port it.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1278633-perfmon-installer.patch

Tested on Windows 2.44 x64 en-US VS2015 build.

User agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:47.0) Gecko/20100101 Firefox/47.0 SeaMonkey/2.44

Comment 2

[Philip Chee]

Comment on attachment 8760856 [details] [diff] [review]
1278633-perfmon-installer.patch

Do you think we should port the UI from Bug 1071880 + Bug 1142937 ?

Comment 3

[Frank-Rainer Grahl (:frg)]

Done
https://hg.mozilla.org/comm-central/rev/0e32f6823f81

Comment 4

[Frank-Rainer Grahl (:frg)]

>> Do you think we should port the UI from Bug 1071880 + Bug 1142937 ?

Looks simple at first glance but I wouldn't want it without an option to turn it off in the ui. Not sure what this does on an old P3 otherwise. 

File a followup bug? Maybe rsx11m can do the ui part. 

rsx11m what do you think?

FRG

Comment 5

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8760856 [details] [diff] [review]
1278633-perfmon-installer.patch

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: Freebie functionality that is already in Firefox missing.
Testing completed (on m-c, etc.): c-r and c-b 
Risk to taking this patch (and alternatives if risky): none 
String changes made by this patch: none.

Comment 6

[rsx11m]

Err, since we don't use AddonWatcher.jsm anyway, does that XPT do anything at all at this time?
I don't know much about the Addons Manager itself.

Comment 7

[Philip Chee]

Comment on attachment 8760856 [details] [diff] [review]
1278633-perfmon-installer.patch

a=me for all branches inc CLOSED TREE

Comment 8

[Frank-Rainer Grahl (:frg)]

>> Do you think we should port the UI from Bug 1071880 + Bug 1142937 ?

I ported the changes for these bugs to 2.47a1 but do not have a test case yet eg. unable to force a notification. I created bug 1282227 to track this.

Comment 9

[Frank-Rainer Grahl (:frg)]

Done

https://hg.mozilla.org/releases/comm-aurora/rev/6ea9fa7cf407
https://hg.mozilla.org/releases/comm-beta/rev/9671300c2e17
https://hg.mozilla.org/releases/comm-release/rev/5084048788ca

Comment 10

[Rainer Bielefeld]

TM for easing queries.

Comment 11

[rsx11m]

TM is supposed to reflect trunk version at the time this landed on comm-central.

Comment 12

[Rainer Bielefeld]

Please see Bug 1293618 comment #38