Closed Bug 1243720 Opened 4 years ago Closed 4 years ago
[e10s] Firefox doesn't respect colors of high contrast mode for web content (Windows)
58 bytes, text/x-review-board-request
STR: enable e10s in FF and turn on high contrast mode in Windows (like high-contrast black). Colors of web content are not affected.
STR: 1) Set computer to use a High Contrast mode. 2) Start Nightly and ensure it is in e10s mode 3) Open any web content (ie yahoo.com) Test result: The web content is not displayed in high contrast Expected result: The web content is displayed in High Contrast Win 7, Nightly 47.0a1, 20160131030347: FAIL - doesn't show High Contrast content (works as expected in non-e10s window) Linux Ubuntu, Nightly 47.0a1, 20160201030241: FAIL - doesn't show High Contrast content even in non-e10 nor e10s Mac 10.9.5, Nightly 47.0a1, 20160201030241: PASS - (using Invert Colors mode on the computer, content is inverted as expected)
Review commit: https://reviewboard.mozilla.org/r/33475/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33475/
Attachment #8715480 - Flags: review?(jmathies)
Comment on attachment 8715480 [details] MozReview Request: Bug 1243720 - Send accessibility theme state down to content process. r?jimm https://reviewboard.mozilla.org/r/33475/#review30455 ::: widget/windows/nsLookAndFeel.cpp:689 (Diff revision 1) > + return lookAndFeelIntCache; I'm surprised this is the only value in here we have to grab from the chrome process. I wonder if there are other bugs out there lurking that haven't been filed yet.
Attachment #8715480 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad69b78ed3e02f9c3255fbab700d049f0debb325 Bug 1243720 - Send accessibility theme state down to the content process on Windows. r=jimm
Comment on attachment 8715480 [details] MozReview Request: Bug 1243720 - Send accessibility theme state down to content process. r?jimm Approval Request Comment [Feature/regressing bug #]: Electrolysis [User impact if declined]: Users who get e10s enabled who rely on high-contrast mode on Windows will not see it enabled in their web content, which is an accessibility problem. [Describe test coverage new/current, TreeHerder]: This has been on Nightly for a few days, and I haven't heard of or seen any issues. I tested the patch manually and confirmed that I can get high-contrast mode in web content with e10s enabled. Unfortunately, I don't believe we have automated tests for this (and I'm not sure they'd be easy to create). [Risks and why]: I'd say it's very low risk. We're just forwarding the "look and feel" setting of "high-contrast mode" to the content. [String/UUID change made/needed]: None.
Attachment #8715480 - Flags: approval-mozilla-aurora?
Marking affected for 46 so that sheriffs will see this uplift request.
Comment on attachment 8715480 [details] MozReview Request: Bug 1243720 - Send accessibility theme state down to content process. r?jimm No problems on nightly, enables high contrast themes with e10s
Attachment #8715480 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.