1243720 - [e10s] Firefox doesn't respect colors of high contrast mode for web content (Windows)

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Loic]

STR: enable e10s in FF and turn on high contrast mode in Windows (like high-contrast black).
Colors of web content are not affected.

Comment 1

[Tracy Walker [:tracy]]

STR:

1) Set computer to use a High Contrast mode.
2) Start Nightly and ensure it is in e10s mode
3) Open any web content (ie yahoo.com)

Test result:  The web content is not displayed in high contrast

Expected result: The web content is displayed in High Contrast

Win 7, Nightly 47.0a1, 20160131030347: FAIL - doesn't show High Contrast content (works as expected in non-e10s window)
Linux Ubuntu, Nightly 47.0a1, 20160201030241:  FAIL - doesn't show High Contrast content even in non-e10 nor e10s
Mac 10.9.5, Nightly 47.0a1, 20160201030241: PASS - (using Invert Colors mode on the computer, content is inverted as expected)

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: Bug 1243720 - Send accessibility theme state down to content process. r?jimm

Review commit: https://reviewboard.mozilla.org/r/33475/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33475/

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 8715480 [details]
MozReview Request: Bug 1243720 - Send accessibility theme state down to content process. r?jimm

https://reviewboard.mozilla.org/r/33475/#review30455

::: widget/windows/nsLookAndFeel.cpp:689
(Diff revision 1)
> +  return lookAndFeelIntCache;

I'm surprised this is the only value in here we have to grab from the chrome process. I wonder if there are other bugs out there lurking that haven't been filed yet.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ad69b78ed3e02f9c3255fbab700d049f0debb325
Bug 1243720 - Send accessibility theme state down to the content process on Windows. r=jimm

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ad69b78ed3e0

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8715480 [details]
MozReview Request: Bug 1243720 - Send accessibility theme state down to content process. r?jimm

Approval Request Comment
[Feature/regressing bug #]:

Electrolysis

[User impact if declined]:

Users who get e10s enabled who rely on high-contrast mode on Windows will not see it enabled in their web content, which is an accessibility problem.

[Describe test coverage new/current, TreeHerder]:

This has been on Nightly for a few days, and I haven't heard of or seen any issues. I tested the patch manually and confirmed that I can get high-contrast mode in web content with e10s enabled. Unfortunately, I don't believe we have automated tests for this (and I'm not sure they'd be easy to create).

[Risks and why]: 

I'd say it's very low risk. We're just forwarding the "look and feel" setting of "high-contrast mode" to the content.

[String/UUID change made/needed]:

None.

Comment 7

[Liz Henry (:lizzard)]

Marking affected for 46 so that sheriffs will see this uplift request.

Comment 8

[Liz Henry (:lizzard)]

Comment on attachment 8715480 [details]
MozReview Request: Bug 1243720 - Send accessibility theme state down to content process. r?jimm

No problems on nightly, enables high contrast themes with e10s

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0c2abe0921d4

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0c2abe0921d4