Closed Bug 1243882 Opened 4 years ago Closed 4 years ago

Block e10s for locales based on Firefox's locale, not the OS

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 47
Tracking Status
e10s m8+ ---
firefox45 --- fixed
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: Felipe, Assigned: Felipe)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
+++ This bug was initially created as a clone of Bug #1234673 +++

The code implemented in bug 1234673 blocks e10s based on the OS's suggested locale for applications. Better would be to block based on the real locale, as there are users who switch locales or use one that is different from their OS.
Attachment #8713344 - Flags: review?(ehsan)
Attachment #8713344 - Flags: review?(jmathies)
Comment on attachment 8713344 [details] [diff] [review]
patch

Review of attachment 8713344 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay.  Apparently bugzilla does nothing unless if you press Publish.  Just came back to this tab after a few days.  :-)
Attachment #8713344 - Flags: review?(ehsan) → review+
np, thanks!
Attachment #8713344 - Flags: review?(jmathies)
https://hg.mozilla.org/mozilla-central/rev/04d23831d950
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Comment on attachment 8713344 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: Improving the code that landed for bug 1234673
[User impact if declined]: Users who use the browser and OS on different locales might not be blocked as expected.
[Describe test coverage new/current, TreeHerder]: Landed on central
[Risks and why]: this is contained to the e10s-decision block of code, so shouldn't have effect for non-e10s users
[String/UUID change made/needed]: none

Since it's simple it would be nice to get this to Beta to start testing the change with the next experiment.
Attachment #8713344 - Flags: approval-mozilla-beta?
Attachment #8713344 - Flags: approval-mozilla-aurora?
> this is contained to the e10s-decision block of code, so shouldn't have effect for non-e10s users
Well, what about the e10s users? We are experimenting with half of the population, so, I do care about these users too.
The purpose of this change is an improvement for the e10s users, and the new code is simpler than the one it replaces
Comment on attachment 8713344 [details] [diff] [review]
patch

ok, thanks. Let's take it. Should be in 45 beta 3.
Attachment #8713344 - Flags: approval-mozilla-beta?
Attachment #8713344 - Flags: approval-mozilla-beta+
Attachment #8713344 - Flags: approval-mozilla-aurora?
Attachment #8713344 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.