1243882 - Block e10s for locales based on Firefox's locale, not the OS

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Attachment: patch

+++ This bug was initially created as a clone of Bug #1234673 +++

The code implemented in bug 1234673 blocks e10s based on the OS's suggested locale for applications. Better would be to block based on the real locale, as there are users who switch locales or use one that is different from their OS.

Comment 1

[(no longer active)]

Comment on attachment 8713344 [details] [diff] [review]
patch

Review of attachment 8713344 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay.  Apparently bugzilla does nothing unless if you press Publish.  Just came back to this tab after a few days.  :-)

Comment 2

[:Felipe Gomes (needinfo for replies!)]

np, thanks!

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/04d23831d950

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/04d23831d950

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8713344 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: Improving the code that landed for bug 1234673
[User impact if declined]: Users who use the browser and OS on different locales might not be blocked as expected.
[Describe test coverage new/current, TreeHerder]: Landed on central
[Risks and why]: this is contained to the e10s-decision block of code, so shouldn't have effect for non-e10s users
[String/UUID change made/needed]: none

Since it's simple it would be nice to get this to Beta to start testing the change with the next experiment.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

> this is contained to the e10s-decision block of code, so shouldn't have effect for non-e10s users
Well, what about the e10s users? We are experimenting with half of the population, so, I do care about these users too.

Comment 7

[:Felipe Gomes (needinfo for replies!)]

The purpose of this change is an improvement for the e10s users, and the new code is simpler than the one it replaces

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8713344 [details] [diff] [review]
patch

ok, thanks. Let's take it. Should be in 45 beta 3.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7e7a6d5bd3a1

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/625d8d4ac52e