Closed Bug 1243929 Opened 4 years ago Closed 4 years ago

Only display JIT view when frame has optimizations

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

defect

Tracking

(firefox47 fixed)

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We should hide this panel when a frame is selected and does not have opt data, or if no frame is selected. Some mechanics for this already exist in details-js-call-tree.js
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Priority: -- → P2
Combined some tests, only displays jit panel when there's info to display

https://treeherder.mozilla.org/#/jobs?repo=try&revision=34eb6af2e162
Attachment #8716409 - Flags: review?(vporof)
Comment on attachment 8716409 [details] [diff] [review]
1243929-jit-display-only-pref.patch

Review of attachment 8716409 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/performance/test/browser_perf-options-show-jit-optimizations.js
@@ +1,4 @@
>  /* Any copyright is dedicated to the Public Domain.
>     http://creativecommons.org/publicdomain/zero/1.0/ */
>  
> +requestLongerTimeout(2);

Can we not split this test instead? Otherwise maybe add a comment describing why we need the longer timeout.
Attachment #8716409 - Flags: review?(vporof) → review+
longer timeout request added in bug 1235788, so moving it over from there
https://hg.mozilla.org/mozilla-central/rev/912f7aa4d70f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.