1243929 - Only display JIT view when frame has optimizations

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Description

[Jordan Santell [:jsantell] [@jsantell]]

We should hide this panel when a frame is selected and does not have opt data, or if no frame is selected. Some mechanics for this already exist in details-js-call-tree.js

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1243929-jit-display-only-pref.patch

Combined some tests, only displays jit panel when there's info to display

https://treeherder.mozilla.org/#/jobs?repo=try&revision=34eb6af2e162

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 8716409 [details] [diff] [review]
1243929-jit-display-only-pref.patch

Review of attachment 8716409 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/performance/test/browser_perf-options-show-jit-optimizations.js
@@ +1,4 @@
>  /* Any copyright is dedicated to the Public Domain.
>     http://creativecommons.org/publicdomain/zero/1.0/ */
>  
> +requestLongerTimeout(2);

Can we not split this test instead? Otherwise maybe add a comment describing why we need the longer timeout.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

longer timeout request added in bug 1235788, so moving it over from there

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/912f7aa4d70f

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/912f7aa4d70f