124393 - VK_HELP

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[timeless]

Windows has it:
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/vkeys_529f.asp

Java2 has it:
http://java.sun.com/products/jdk/1.2/docs/api/java/awt/event/KeyEvent.html

Dom has it:
http://www.w3.org/TR/1999/WD-DOM-Level-2-19990719/events.html

According to Bug 88739 Comment 42, Mac has a Help key which we are currently mapping to insert.
http://lxr.mozilla.org/seamonkey/source/widget/src/mac/nsMacEventHandler.cpp#820

Comment 1

[Kathleen :Brade]

Attachment: 1-line addition of VK_HELP

Comment 2

[joki (gone)]

Comment on attachment 71323 [details] [diff] [review]
1-line addition of VK_HELP

r=joki

Comment 3

[Simon Fraser [no longer active]]

Comment on attachment 71323 [details] [diff] [review]
1-line addition of VK_HELP

sr=sfraser

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 71323 [details] [diff] [review]
1-line addition of VK_HELP

a=roc+moz for 0.9.9

Comment 5

[Kathleen :Brade]

Attachment: Mac-specific fix for handling VK_HELP instead of VK_INSERT

Mac-specific fix / cleanup to handle VK_HELP instead of VK_INSERT.
Last I checked, I didn't see any usage of VK_INSERT in lxr.mozilla.org (on any
platform).  This patch also does some cleanup (remove tabs on affected lines)
and goes directly to the domeventkey constants rather than using the NS_VK_*
constants which are redundant and hopefully going away some day.

Comment 6

[Kathleen :Brade]

Pink--please review Mac-specific patch
Simon--please sr Mac-specific patch

Comment 7

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 71686 [details] [diff] [review]
Mac-specific fix for handling VK_HELP instead of VK_INSERT

r=pink

Comment 8

[Simon Fraser [no longer active]]

The patch is very hard to read. Would it be possible to attach an intermediate
patch that still has the NS_VK key codes, and doesn't show whitespace changes?
Or perhaps you could describe exactly which key mappings changed in the patch?

Comment 9

[Kathleen :Brade]

The whitespace changes are mostly limited to lines where NS_VK changes happened.
The essential change is from NS_VK_INSERT to nsIDOMKeyEvent::VK_HELP

I also changed these things:
  removed unnecessary headers
  moved the clear key and escape key out of the "modifier" section
  removed a comment at the end of a } which didn't seem necessary 
     (just added clutter imo)
  renamed kInsertKeyCode to kHelpKeyCode
  uncommented kCommandKeyCode since VK_META key is now defined
     (not that we have code that would trigger this case or any other mod keys)

Comment 10

[Simon Fraser [no longer active]]

Comment on attachment 71686 [details] [diff] [review]
Mac-specific fix for handling VK_HELP instead of VK_INSERT

sr=sfraser

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 71686 [details] [diff] [review]
Mac-specific fix for handling VK_HELP instead of VK_INSERT

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 12

[Kathleen :Brade]

Mac-specific fix checked into trunk

Comment 13

[Vladimir Ermakov]

Attachment: testcase

Comment 14

[Vladimir Ermakov]

Attachment: umm, the real testcase

Comment 15

[Vladimir Ermakov]

verifying on build 2002-04-12-03-trunk on windows 98 and Mac OSX

Comment 16

[Steffen Wilberg]

VK_HELP is reported as not working, see bug 88739 comment 70 and 71 and the
testcase in that bug. Reopening.

Comment 17

[Steffen Wilberg]

VK_HELP has been reported to be triggered by Space, as well as just any key when
FAYT is enabled. I've tried to use VK_HELP in Firefox on Mac, see bug 251165,
but that caused bug 252750.

Comment 18

[Steffen Wilberg]

Attachment: patch/testcase: make VK_HELP open Help Contents in Seamonkey

Use this patch to test VK_HELP on Seamonkey.
On VK_HELP, Help Contents are opened; it should also display that in the menu.
Note that VK_HELP is triggered by any key on Windows right now...

Comment 19

[Steffen Wilberg]

VK_HELP finally works with the fix in bug 252750, which is already in the trunk
and the aviary branch. Pressing the Help key now brings up Help Contents in
Firefox on Mac.
-> fixed again.