Closed Bug 251165 Opened 18 years ago Closed 18 years ago

F1 on Win/*nix should bring up Help Contents

Categories

(SeaMonkey :: Help Viewer, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

Details

(Keywords: fixed-aviary1.0)

Attachments

(1 file)

Every single windows app uses F1 to bring up Help.
The respective SeaMonkey bug is bug 88739.

Keys to use are VK_F1 and VK_HELP. The latter only works on Mac:
http://lxr.mozilla.org/aviarybranch/search?string=VK_HELP
Taking.

I don't have a Mac, so I hope this is a recent Mac keyboard:
http://www.internet4classrooms.com/mackeyboard.htm
This means that the help key should work without key modifiers.
Assignee: rlk → steffen.wilberg
Help key for Mac, F1 for other platforms.
Attachment #153033 - Flags: review?(rlk)
Flags: blocking-aviary1.0RC1?
Flags: blocking-aviary1.0?
Flags: blocking-aviary1.0RC1?
Flags: blocking-aviary1.0RC1+
Flags: blocking-aviary1.0?
Flags: blocking-aviary1.0+
Priority: -- → P3
Comment on attachment 153033 [details] [diff] [review]
patch [checked in: comment 6]

>@@ -58,9 +69,6 @@
>             position="1"
>             accesskey="&helpContents.accesskey;"
>             key="key_openHelp"
>-# Use the Thunderbird content pack if we're building thunderbird. Otherwise use the Firefox content
>-# pack. We should use else instead of elseif to prevent build errors if MOZ_PHOENIX and MOZ_THUNDERBIRD
>-# are not built.

why remove this comment? its still valid here too.

r=me with that comment restored.
Attachment #153033 - Flags: review?(rlk) → review+
Actually, I think the correct help key is cmd+? on mac, see bug 88739, comment #71 .
We're going to try VK_HELP. There's no harm done if it doesn't work, as long as
it doesn't break the menu or displays weird characters.

Again, I don't have a Mac, but the link from comment 1 says for the Help key:
"Help - Brings up the Help index for the application you are working in. If you
are in the Finder this brings up Mac OS help."

I'm not sure about Cmd+?. The above mentioned document says: "Cmd+? to launch
the help menu in the Finder". CCing Aaron.
Checked in br & trunk 2004-07-19 07:14-07:15 (with the comment restored).
-> fixed.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox1.0beta
Tracy, can you test if the Help key on a Mac brings up Help Contents, like F1
does on Windows and *nix, please?
Builds 07/19 and newer.
Help key (or cmd+?) does not open Help on Mac OSX with FF0.9+ build
2004-07-19-10-0.9

Comment 5 noted concern about possible menu breakage.  With this build the menu
looks fine.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Steffen, there seem to be a mozdev bug dealing with the same problem:
http://bugzilla.mozdev.org/show_bug.cgi?id=5409 It was fixed in June. But it
doesn't looks like this has been checked in to the FF trunk yet.
Stefan, that must have been the code I replaced. VK_HELP was used before, but
that only exists on Mac, and seems to be broken there when looking at comment 8.
Land it now. DTD changes aren't likely to get easy approval after RC1. 
Flags: blocking-aviary1.0+ → blocking-aviary1.0-
Depends on: 124393
So VK_HELP doesn't work at all. I tried to use Cmd+? but I can't get that to
work either with |key="?" modifiers="control"|. It displays Ctrl+? in the menu,
but it doesn't bring up Help Contents.
(In reply to comment #12)
> So VK_HELP doesn't work at all. I tried to use Cmd+? but I can't get that to
> work either with |key="?" modifiers="control"|. It displays Ctrl+? in the menu,
> but it doesn't bring up Help Contents.

No, VK_HELP doesn't work at all. Maybe the real solution is making VK_HELP work.
From what it looks like to me, it was first created somewhere in bug 88739.

The bug stefan_h noted does checkin the code you posted, so it does not work on
the Mac.
Attachment #153033 - Attachment description: patch → patch [checked in: comment 6]
This might have caused bug 252750, "space goes to help window" (Mac OS X).
could the changes here have caused bug 253603? in that bug, even the menu item
fails to bring up Help Contents (linux and windows trunk).
Bug 252750 will remove the VK_HELP keybinding on Mac for now.
I filed bug 253693 for (re)introducing either VK_HELP or Cmd+? on Mac once the
problems with these are sorted out.

Reducing this bug to Windows/Linux, which is fixed already, see comment 6.
Status: REOPENED → RESOLVED
Closed: 18 years ago18 years ago
No longer depends on: 124393
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
Summary: F1 on Win/*nix, Help key on Mac doesn't bring up Help → F1 on Win/*nix should bring up Help Contents
No longer blocks: 250631
Flags: review+
Flags: blocking-aviary1.0PR+
Flags: blocking-aviary1.0-
Product: Firefox → Toolkit
Target Milestone: Firefox1.0beta → ---
Status: RESOLVED → VERIFIED
Product: Toolkit → Seamonkey
You need to log in before you can comment on or make changes to this bug.