Closed Bug 1243932 Opened 5 years ago Closed 5 years ago

update uses of some nsIX509CertDB functions when bug 1241646 lands

Categories

(MailNews Core :: Security: S/MIME, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 47.0

People

(Reporter: keeler, Assigned: mkmelin)

References

Details

Attachments

(1 file)

bug 1241646 is removing some unnecessary parameters on nsIX509CertDB functions (to be specific, findCertByNickname, findCertByDBKey, findCertNicknames, findCertByEmailAddress, and importCertsFromFile). Any uses of these in the comm-central tree will need to be updated. For instance, the call to FindCertByEmailAddress in nsMsgComposeSecure::MimeCryptoHackCerts:

https://dxr.mozilla.org/comm-central/rev/8b8bcdeb0dca23f20d5f79054bbd046fea1eedb3/mailnews/extensions/smime/src/nsMsgComposeSecure.cpp#982

(basically, s/nullptr, //)
bug 1241646 is now on inbound

Of the changed functions, only two were in use in mailnews/
    findCertByNickname
[x] findCertByDBKey
    findCertNicknames
[x] findCertByEmailAddress
    importCertsFromFile

Cold-coded, but it's just removing null args.
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #8714981 - Flags: review?(Pidgeot18)
Duplicate of this bug: 1245510
Can we review this quickly since it caused bustage.
Comment on attachment 8714981 [details] [diff] [review]
bug1243932_nsIX509CertDB_update.patch

Review of attachment 8714981 [details] [diff] [review]:
-----------------------------------------------------------------

Seems straightforward. Thanks for the bustage fix.
Attachment #8714981 - Flags: review?(Pidgeot18) → review+
https://hg.mozilla.org/comm-central/rev/c86d69003d74a01dfdaeba85b6ee5c104dcbba5f
Bug 1243932 - Update uses of some nsIX509CertDB functions following bug 1241646. r=aleth a=bustage fix CLOSED TREE
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 47.0
You need to log in before you can comment on or make changes to this bug.