Closed Bug 1244091 Opened 4 years ago Closed 3 years ago
Module Info usage with Lazy Log Module in /toolkit/xre
Replace the use of PRLogModuleInfo with LazyLogModule in > ./toolkit/xre/nsUpdateDriver.cpp:79: sUpdateLog = PR_NewLogModule("updatedriver"); This bug is opened separately because this class is invoked in the startup sequence of various components other than the browser, which use the XRE toolkit. Fixing it requires introducing XPCOM into the components which may not use it. Also see bug 1219482 comment 12
I tested this as part of a larger rollup , the assertion no longer seems to be an issue. The best I can tell nsAppRunner uses ScopedXPCOM which calls |NS_InitXPCOM2| which calls |LogModule::Init| so I think we're good.  https://treeherder.mozilla.org/#/jobs?repo=try&revision=f07888328f5d44a51b5c4c457f819546d937a95d
Attachment #8854133 - Flags: review?(nfroyd)
Attachment #8854133 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3b4cf61e1479b86f448c3790883956b9a06740b Bug 1244091 - Switch nsUpdateDriver to LazyLogModule. r=froydnj
You need to log in before you can comment on or make changes to this bug.