1244091 - Replace PRLogModuleInfo usage with LazyLogModule in /toolkit/xre

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[sajitk]

Replace the use of PRLogModuleInfo with LazyLogModule in

> ./toolkit/xre/nsUpdateDriver.cpp:79:    sUpdateLog = PR_NewLogModule("updatedriver");

This bug is opened separately because this class is invoked in the startup sequence of various components other than the browser, which use the XRE toolkit.
Fixing it requires introducing XPCOM into the components which may not use it.

Also see bug 1219482 comment 12

Comment 1

[Eric Rahm [:erahm]]

Attachment: Switch nsUpdateDriver to LazyLogModule

I tested this as part of a larger rollup [1], the assertion no longer seems to
be an issue. The best I can tell nsAppRunner uses ScopedXPCOM which calls
|NS_InitXPCOM2| which calls |LogModule::Init| so I think we're good.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=f07888328f5d44a51b5c4c457f819546d937a95d

Comment 2

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b3b4cf61e1479b86f448c3790883956b9a06740b
Bug 1244091 - Switch nsUpdateDriver to LazyLogModule. r=froydnj

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b3b4cf61e147