Closed Bug 1244091 Opened 4 years ago Closed 3 years ago

Replace PRLogModuleInfo usage with LazyLogModule in /toolkit/xre

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: sajitk, Assigned: erahm)

References

Details

Attachments

(1 file)

Replace the use of PRLogModuleInfo with LazyLogModule in

> ./toolkit/xre/nsUpdateDriver.cpp:79:    sUpdateLog = PR_NewLogModule("updatedriver");

This bug is opened separately because this class is invoked in the startup sequence of various components other than the browser, which use the XRE toolkit.
Fixing it requires introducing XPCOM into the components which may not use it.

Also see bug 1219482 comment 12
Blocks: 1219461
I tested this as part of a larger rollup [1], the assertion no longer seems to
be an issue. The best I can tell nsAppRunner uses ScopedXPCOM which calls
|NS_InitXPCOM2| which calls |LogModule::Init| so I think we're good.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=f07888328f5d44a51b5c4c457f819546d937a95d
Attachment #8854133 - Flags: review?(nfroyd)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Attachment #8854133 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/b3b4cf61e147
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.