Closed Bug 1244143 Opened 4 years ago Closed 4 years ago

Record whether or not an artifact build was used in build telemetry data

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: dminor, Assigned: dminor)

References

Details

Attachments

(1 file)

We need to record whether or not an artifact build was used in the telemetry data - artifact builds should be faster, and we'd like to know how many people are using them.
dminor: thanks for filing this.  How much of the local mozconfig are we comfortable capturing?  For @mozilla.com addresses, I hope it's a lot.  If we did this, it would let us know if --enable-artifact-builds was enabled; but it might also be helpful to know how many folks put their objdir in the srcdir, for example (which has pros and cons); or how many people are using dated options; or ...
That's a good point. My first thought is that we are better off making a list of parsed values we'd like to extract from mach rather than just slurping up the whole file and risk accidentally getting something we shouldn't see, but maybe I'm being too conservative here.
Hopefully we could submit the entire build config (substs, defines, topscrdir, topobjdir, etc.). Inputs to the build all seem within scope.
(In reply to Chris Manchester [:chmanchester] from comment #3)
> Hopefully we could submit the entire build config (substs, defines,
> topscrdir, topobjdir, etc.). Inputs to the build all seem within scope.

That makes sense to me. I'll morph the bug accordingly.
Summary: Record whether or not an artifact build was used in build telemetry data → Record build config in telemetry data
Status: NEW → ASSIGNED
This adds the defines, substs, topoutdir and topsrcdir configuration values
to the telemetry data we are currently collecting. This adds about 70k of
data, but probably ends up being better than having to iterate on adding
values we care about piecemeal.

Review commit: https://reviewboard.mozilla.org/r/33463/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33463/
Attachment #8715460 - Flags: review?(gps)
Attachment #8715460 - Flags: review?(gps)
Comment on attachment 8715460 [details]
MozReview Request: Bug 1244143 - Record whether or not an artifact build was used in build telemetry data r?gps

https://reviewboard.mozilla.org/r/33463/#review30173

::: python/mozbuild/mozbuild/mach_commands.py:501
(Diff revision 1)
> +            telemetry_data['defines'] = self.defines
> +            telemetry_data['substs'] = self.substs
> +            telemetry_data['topsrcdir'] = self.topsrcdir
> +            telemetry_data['topobjdir'] = self.topobjdir

The build config data may contain PII, notably filesystem paths, which may contain a username. 

People could also argue that this data could be used to gleen information about a user's machine to help construct an attack. e.g. it may identify they are running a known vulnerable version of some piece of software. This data makes the Telemetry database an attactive target for an attacker wishing to compromise a Firefox developer's machine.

As much as I want to record all of the things, I think we should cherry pick values for now. I don't think mass capturing of the full build configuration is warranted. Let's drop this for now.
Fair enough, I'll morph this back to the original bug, which is to capture whether an artifact build was done, which should be safe.
Summary: Record build config in telemetry data → Record whether or not an artifact build was used in build telemetry data
Attachment #8715460 - Attachment description: MozReview Request: Bug 1244143 - Record build config in telemetry data r?gps → MozReview Request: Bug 1244143 - Record whether or not an artifact build was used in build telemetry data r?gps
Attachment #8715460 - Flags: review?(gps)
Comment on attachment 8715460 [details]
MozReview Request: Bug 1244143 - Record whether or not an artifact build was used in build telemetry data r?gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33463/diff/1-2/
Comment on attachment 8715460 [details]
MozReview Request: Bug 1244143 - Record whether or not an artifact build was used in build telemetry data r?gps

https://reviewboard.mozilla.org/r/33463/#review30755
Attachment #8715460 - Flags: review?(gps) → review+
sorry had to back this out , since this caused trouble on 10.7 opt like https://treeherder.mozilla.org/logviewer.html#?job_id=21427471&repo=mozilla-inbound
Flags: needinfo?(dminor)
Comment on attachment 8715460 [details]
MozReview Request: Bug 1244143 - Record whether or not an artifact build was used in build telemetry data r?gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33463/diff/2-3/
https://hg.mozilla.org/mozilla-central/rev/4137fa2415c8
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Flags: needinfo?(dminor)
Depends on: 1253039
No longer depends on: 1253039
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.