Closed
Bug 1244169
Opened 8 years ago
Closed 8 years ago
Tabs data adapter
Categories
(Firefox OS Graveyard :: Sync, defect)
Tracking
(blocking-b2g:-, feature-b2g:2.6+)
People
(Reporter: ferjm, Assigned: selee)
References
Details
Attachments
(2 files)
No description provided.
Reporter | ||
Updated•8 years ago
|
Reporter | ||
Updated•8 years ago
|
blocking-b2g: --- → 2.6?
blocking-b2g: 2.6? → -
feature-b2g: --- → 2.6+
Target Milestone: 2.6 S7 - 2/12 → 2.6 S10 - 3/25
Assignee | ||
Comment 1•8 years ago
|
||
The attachment is an sample of Tab records. Here is a reference for Tab record data format: http://docs.services.mozilla.com/sync/objectformats.html#tabs
Comment 2•8 years ago
|
||
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8719735 [details] [review] [gaia] weilonge:seanlee/DataSync/master/Bug1244169 > mozilla-b2g:master Hey Michiel, Fernando, Could you help to give the patch a feedback when I am implementing unit-test? Thank you!
Attachment #8719735 -
Flags: feedback?(mbdejong)
Attachment #8719735 -
Flags: feedback?(ferjmoreno)
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8719735 [details] [review] [gaia] weilonge:seanlee/DataSync/master/Bug1244169 > mozilla-b2g:master Hey Michiel, Fernando, The patch is added the unit tests. Could you help to review it? Thank you!
Attachment #8719735 -
Flags: review?(mbdejong)
Attachment #8719735 -
Flags: review?(ferjmoreno)
Attachment #8719735 -
Flags: feedback?(mbdejong)
Attachment #8719735 -
Flags: feedback?(ferjmoreno)
Comment 5•8 years ago
|
||
Left a few comments on github.
Updated•8 years ago
|
Attachment #8719735 -
Flags: review?(mbdejong) → review+
Reporter | ||
Comment 6•8 years ago
|
||
Comment on attachment 8719735 [details] [review] [gaia] weilonge:seanlee/DataSync/master/Bug1244169 > mozilla-b2g:master LGTM. It would be good to extract the common logic from all adapters. With this one we will have mostly the exact same code in three different places. It's ok for now though.
Attachment #8719735 -
Flags: review?(ferjmoreno) → review+
Assignee | ||
Comment 7•8 years ago
|
||
Hi Fernando, Michiel, Thanks for your review. We can discuss if we can do the refactor at a new bug or the existing bug 1224183.
Assignee: nobody → selee
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•8 years ago
|
||
landed on master: https://github.com/mozilla-b2g/gaia/commit/ee9bea2745b19d53d1f8ccb2bef0b235414465fc
You need to log in
before you can comment on or make changes to this bug.
Description
•