Tabs data adapter

RESOLVED FIXED in 2.6 S10 - 3/25

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ferjm, Assigned: selee)

Tracking

unspecified
2.6 S10 - 3/25
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:-, feature-b2g:2.6+)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Reporter)

Updated

3 years ago
Blocks: 1244168, 824026
Target Milestone: --- → 2.6 S7 - 2/12
(Reporter)

Updated

3 years ago
blocking-b2g: --- → 2.6?

Updated

3 years ago
blocking-b2g: 2.6? → -
feature-b2g: --- → 2.6+
Target Milestone: 2.6 S7 - 2/12 → 2.6 S10 - 3/25
(Assignee)

Comment 1

3 years ago
Created attachment 8719697 [details]
Tabs data sample from Firefox Sync Service

The attachment is an sample of Tab records. Here is a reference for Tab record data format:
http://docs.services.mozilla.com/sync/objectformats.html#tabs
Created attachment 8719735 [details] [review]
[gaia] weilonge:seanlee/DataSync/master/Bug1244169 > mozilla-b2g:master
(Assignee)

Comment 3

3 years ago
Comment on attachment 8719735 [details] [review]
[gaia] weilonge:seanlee/DataSync/master/Bug1244169 > mozilla-b2g:master

Hey Michiel, Fernando,

Could you help to give the patch a feedback when I am implementing unit-test?
Thank you!
Attachment #8719735 - Flags: feedback?(mbdejong)
Attachment #8719735 - Flags: feedback?(ferjmoreno)
(Assignee)

Comment 4

3 years ago
Comment on attachment 8719735 [details] [review]
[gaia] weilonge:seanlee/DataSync/master/Bug1244169 > mozilla-b2g:master

Hey Michiel, Fernando,

The patch is added the unit tests.
Could you help to review it? Thank you!
Attachment #8719735 - Flags: review?(mbdejong)
Attachment #8719735 - Flags: review?(ferjmoreno)
Attachment #8719735 - Flags: feedback?(mbdejong)
Attachment #8719735 - Flags: feedback?(ferjmoreno)
Left a few comments on github.
Attachment #8719735 - Flags: review?(mbdejong) → review+
(Reporter)

Comment 6

3 years ago
Comment on attachment 8719735 [details] [review]
[gaia] weilonge:seanlee/DataSync/master/Bug1244169 > mozilla-b2g:master

LGTM.

It would be good to extract the common logic from all adapters. With this one we will have mostly the exact same code in three different places. It's ok for now though.
Attachment #8719735 - Flags: review?(ferjmoreno) → review+
(Assignee)

Comment 7

3 years ago
Hi Fernando, Michiel,

Thanks for your review. We can discuss if we can do the refactor at a new bug or the existing bug 1224183.
Assignee: nobody → selee
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Blocks: 1250834
You need to log in before you can comment on or make changes to this bug.