Closed
Bug 1244258
Opened 9 years ago
Closed 9 years ago
Back out bug 1201327 from Beta
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
References
Details
Attachments
(1 file)
19.36 KB,
patch
|
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Bug 1201327 caused a bunch of regressions (bug 1227327, bug 1227012, bug 1239856) and I won't be able to fix them in time for Firefox 45. So we should back out bug 1201327 on Beta.
(I do have a plan for fixing it, and I'm confident about landing the real fix in time for Firefox 46.)
Assignee | ||
Comment 1•9 years ago
|
||
Approval Request Comment
[Feature/regressing bug #]: bug 1201327
[User impact if declined]: painting wrong images on some sites (not respecting changes to background-position)
[Describe test coverage new/current, TreeHerder]: this was just an optimization, test coverage is fairly good
[Risks and why]: very low, just a backout
[String/UUID change made/needed]: none
Attachment #8713767 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 2•9 years ago
|
||
Updated•9 years ago
|
status-firefox45:
--- → affected
status-firefox47:
affected → ---
Comment 3•9 years ago
|
||
Comment on attachment 8713767 [details] [diff] [review]
beta backout
OK; let's back out it.
Should be in 45 beta 2.
Attachment #8713767 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 4•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•9 years ago
|
||
I've landed the backout on Aurora 47, too:
https://hg.mozilla.org/releases/mozilla-aurora/rev/f3a938f7ab1d
Approval for that was given in bug 1201327 comment 28.
You need to log in
before you can comment on or make changes to this bug.
Description
•