Closed Bug 1244321 Opened 5 years ago Closed 5 years ago

Please sign the privacy.clearOnShutdown.passwords hotfix xpi (v20160128.01)

Categories

(addons.mozilla.org Graveyard :: Administration, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: MattN, Assigned: kmag)

References

Details

Attachments

(1 file)

5.67 KB, application/x-xpinstall
Details
To generate the XPI, do the following:

hg clone https://hg.mozilla.org/releases/firefox-hotfixes
cd firefox-hotfixes
HOTFIX=v20160128.01 make package

Then we need to sign the xpi generated at build/hotfix-v20160128.01.xpi

Please deploy to addons-dev.allizom.org for QA
Attached file Signed hotfix
Signed hotfix is attached. I'm having trouble uploading it to the staging server, at the moment.
Verification steps:

A) Verify that you can reproduce the bug without the hotfix using these STR:
WARNING: This will delete all logins without the fix/hotfix.
1) Run a version prior to Fx44 with the prefs:
* privacy.clearOnShutdown.passwords = True (add it as new in versions after 42)
* privacy.sanitize.sanitizeOnShutdown = false
* privacy.sanitize.migrateClearSavedPwdsOnExit = false or unspecified
2) Add some saved passwords (they will be deleted)
3) Upgrade to Fx44

Expected result:
All logins are still present in Preferences > Security > Saved Logins… and the "Remember Logins" checkbox is still checked.

Actual result:
All logins are deleted. The "Remember Logins" checkbox is unchecked.

B) Perform the steps at https://wiki.mozilla.org/Add-ons/Hotfix#Testing_the_hotfix_locally
C) Perform the steps at https://wiki.mozilla.org/Add-ons/Hotfix#Testing_the_hotfix_on_the_staging_server
D) With the hotfix installed in pre-44, verify that you get the "Expected result" in the STR from (A) upon upgrading to Fx44 instead of the "Actual result".
Anthony, could you please test the hotfix once it's on the staging server? Kris, could you please let us know when hotfix is on the staged server? You mentioned having difficulty upload it in a previous comment.
Flags: needinfo?(kmaglione+bmo)
Flags: needinfo?(anthony.s.hughes)
To clarify, for (D), perform STR steps 1-2, install the hotfix then do step 3.
I confirm that the local hotfix seems to work as expected.

A:
1) Install Firefox 43 and started with a new profile
2) Set prefs in comment 3
3) Saved some website passwords
4) Updated to Fx44
> Passwords removed, 'Remember logins for sites' unchecked

B:
1) Install Firefox 43 and started with a new profile
2) Set prefs in comment 3
3) Saved some website passwords
4) Install the hotfix .xpi
5) Update to Fx44
> Passwords remain, 'Remember logins for sites' checked
Flags: needinfo?(anthony.s.hughes)
The hotfix is now live on the staging servers.
Flags: needinfo?(kmaglione+bmo)
(In reply to Kris Maglione [:kmag] from comment #7)
> The hotfix is now live on the staging servers.

Same result as above with the staged hotfix (works as expected).
(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #8)
> (In reply to Kris Maglione [:kmag] from comment #7)
> > The hotfix is now live on the staging servers.
> 
> Same result as above with the staged hotfix (works as expected).

Awesome work Anthony! Thank you.
Re-assigning the bug to amo team for final deployment now that QA sign off is done.
Assignee: nobody → kmaglione+bmo
Flags: needinfo?(kmaglione+bmo)
The hotfix has been deployed to production.
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(kmaglione+bmo)
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.