Closed Bug 1244324 Opened 8 years ago Closed 8 years ago

One-byte buffer overruns in libnssutil UTF-8 test code

Categories

(NSS :: Test, defect)

Product:
NSS
Component:
Test
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox47 affected, firefox-esr4550+ fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox47 --- affected
firefox-esr45 50+ fixed

People

(Reporter: jld, Assigned: jld)

References

Details

Attachments

(1 file)

Patch
1.00 KB, patch
ttaubert
: review+
keeler
: feedback+
Details | Diff | Splinter Review 
Not a security problem per se, and not even part of the build (see also bug 1244309), but utf8.c has some tests that try to concatenate a bunch of test case strings with strcat() and neglect to allocate space for the null terminators.
Attached patch Patch — — Splinter Review 

        Attachment #8713861 -
        Flags: review?(dkeeler)

    
    

    
  
Comment on attachment 8713861 [details] [diff] [review]
Patch

Review of attachment 8713861 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, but I'm not an NSS peer.

        Attachment #8713861 -
        Flags: review?(dkeeler) → feedback+

        Attachment #8713861 -
        Flags: review?(ttaubert)

    
    

    
  
Comment on attachment 8713861 [details] [diff] [review]
Patch

Review of attachment 8713861 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

        Attachment #8713861 -
        Flags: review?(ttaubert) → review+
Status: NEW → ASSIGNED

    
    

    
  
Not sure who does checkin-needed for NSS, but let's see what happens.
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/projects/nss/rev/b6bcbd62e833
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 3.23

    
    

    
  
Tracking upstream NSS 3.21.3 security updates for the ESR-45 "50+" release.

          status-firefox-esr45:
          --- → affected

          tracking-firefox-esr45:
          --- → 50+

    
  
Blocks: 1310009

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: