1244569 - [PDF Viewer] PDF rendering broken with Firefox 44 on Mac OSX after SkiaGL for canvas turned on

Status: RESOLVED DUPLICATE of bug 1249312

(Firefox :: PDF Viewer, defect, P2)

Description

[ed.wiesmeier3]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20151029151421

Steps to reproduce:

1) tried version 44.0 on pc - no problem
2) went back to version 42.0 on mac - no problem
3) re-downloaded version 44.0 on mac - still broken


Actual results:

pdf output is totally garbled


Expected results:

pdf output should not be garbled

Comment 1

[Loic]

Could you attach some screenshots, please.

Comment 2

[ed.wiesmeier3]

Attachment: screenshots of pdf viewer

Comment 3

[ed.wiesmeier3]

Attachment: another screenshot

Comment 4

[Loic]

Did you test with HWA disabled?
https://support.mozilla.org/en-US/kb/forum-response-disable-hardware-acceleration (restart FF to apply)

Comment 5

[woranl]

I have the same issue with Firefox 44.0.  Turning off hardware acceleration helps solve this problem. PDF can be rendered correctly on Firefox 43.0.4 with hardware acceleration on.  This problem only starts to occur in Firefox 44.0.

Comment 6

[Loic]

woranl, could you install the command-line tool Mozregression to find a regression range in FF44.
See http://mozilla.github.io/mozregression/ for details (be sure python 2.7 is installed).

Comment 7

[woranl]

I can't get Mozregression to install even after upgrading to python 2.7.  Enough time wasted.  Good luck on tracking down the bug.

Comment 8

[Loic]

ed, can you try to find a regression range with mozregression, please.

Comment 9

[ed.wiesmeier3]

i'm willing to give it a try - what is mozregression and is there a tutorial somewhere?

Comment 10

[Loic]

Yes, all is explained here: http://mozilla.github.io/mozregression/

Comment 11

[Ryan VanderMeulen [:RyanVM]]

I haven't been able to reproduce any corruption on a 2013 MBP Retina with a sampling of PDFs. Were there any specific ones showing the issue that could be provided?

Rares, maybe someone on the SV team has 10.6 hardware to test on too?

Comment 12

[ed.wiesmeier3]

the bug appears on a macbook 4,1 running osx 10.6.8
all pdf's are garbled

Comment 13

[Loic]

we really need a regression range to narrow down the regressing bug. Could you do that, please?

Comment 14

[ed.wiesmeier3]

ok so i went to the mozregression and followed the directions to install python and mozregression (i think)
below is the terminal session - am i good to go or are there errors that need to be addressed first?

Last login: Thu Feb  4 11:12:08 on console
Ed-Wiesmeiers-MacBook:~ ediii$ sudo easy_install pip
Password:
Searching for pip
Reading http://pypi.python.org/simple/pip/
Best match: pip 8.0.2
Downloading https://pypi.python.org/packages/source/p/pip/pip-8.0.2.tar.gz#md5=3a73c4188f8dbad6a1e6f6d44d117eeb
Processing pip-8.0.2.tar.gz
Running pip-8.0.2/setup.py -q bdist_egg --dist-dir /tmp/easy_install-Pqnm6u/pip-8.0.2/egg-dist-tmp-qS23df
warning: no previously-included files found matching '.coveragerc'
warning: no previously-included files found matching '.mailmap'
warning: no previously-included files found matching '.travis.yml'
warning: no previously-included files found matching '.landscape.yml'
warning: no previously-included files found matching 'pip/_vendor/Makefile'
warning: no previously-included files found matching 'tox.ini'
warning: no previously-included files found matching 'dev-requirements.txt'
warning: no previously-included files found matching 'appveyor.yml'
no previously-included directories found matching '.travis'
no previously-included directories found matching 'docs/_build'
no previously-included directories found matching 'contrib'
no previously-included directories found matching 'tasks'
no previously-included directories found matching 'tests'
Adding pip 8.0.2 to easy-install.pth file
Installing pip script to /usr/local/bin
Installing pip2.6 script to /usr/local/bin
Installing pip2 script to /usr/local/bin

Installed /Library/Python/2.6/site-packages/pip-8.0.2-py2.6.egg
Processing dependencies for pip
Finished processing dependencies for pip
Ed-Wiesmeiers-MacBook:~ ediii$ sudo pip2 install -U mozregression
DEPRECATION: Python 2.6 is no longer supported by the Python core team, please upgrade your Python. A future version of pip will drop support for Python 2.6
The directory '/Users/ediii/Library/Caches/pip/http' or its parent directory is not owned by the current user and the cache has been disabled. Please check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
The directory '/Users/ediii/Library/Caches/pip' or its parent directory is not owned by the current user and caching wheels has been disabled. check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Collecting mozregression
/Library/Python/2.6/site-packages/pip-8.0.2-py2.6.egg/pip/_vendor/requests/packages/urllib3/util/ssl_.py:315: SNIMissingWarning: An HTTPS request has been made, but the SNI (Subject Name Indication) extension to TLS is not available on this platform. This may cause the server to present an incorrect TLS certificate, which can cause validation failures. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#snimissingwarning.
  SNIMissingWarning
/Library/Python/2.6/site-packages/pip-8.0.2-py2.6.egg/pip/_vendor/requests/packages/urllib3/util/ssl_.py:120: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Downloading mozregression-2.3.0.tar.gz (45kB)
    100% |████████████████████████████████| 49kB 546kB/s 
    Complete output from command python setup.py egg_info:
    mozregression currently require python >=2.7 and <3.
    
    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /private/tmp/pip-build-ONKXZb/mozregression
/Library/Python/2.6/site-packages/pip-8.0.2-py2.6.egg/pip/_vendor/requests/packages/urllib3/util/ssl_.py:120: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
Ed-Wiesmeiers-MacBook:~ ediii$

Comment 15

[Loic]

Mozregression is python 2.7 package, not 2.6.

Comment 16

[ed.wiesmeier3]

ok so i installed python 2.7 (i think) and then did the following:

Last login: Sat Feb 13 10:20:57 on ttys000
Ed-Wiesmeiers-MacBook:~ ediii$ sudo pip2 install -U mozregression
Password:
The directory '/Users/ediii/Library/Caches/pip/http' or its parent directory is not owned by the current user and the cache has been disabled. Please check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
The directory '/Users/ediii/Library/Caches/pip' or its parent directory is not owned by the current user and caching wheels has been disabled. check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Collecting mozregression
  Downloading mozregression-2.3.0.tar.gz (45kB)
    100% |████████████████████████████████| 49kB 777kB/s 
Collecting mozfile>=1.2 (from mozregression)
  Downloading mozfile-1.2.tar.gz
Collecting mozprofile>=0.28 (from mozregression)
  Downloading mozprofile-0.28.tar.gz
Collecting mozrunner>=6.11 (from mozregression)
  Downloading mozrunner-6.11.tar.gz (62kB)
    100% |████████████████████████████████| 65kB 781kB/s 
Collecting BeautifulSoup>=3.0.4 (from mozregression)
  Downloading BeautifulSoup-3.2.1.tar.gz
Collecting mozinstall>=1.12 (from mozregression)
  Downloading mozInstall-1.12.tar.gz
Collecting mozinfo>=0.9 (from mozregression)
  Downloading mozinfo-0.9.tar.gz
Collecting mozlog>=3.0 (from mozregression)
  Downloading mozlog-3.1.tar.gz (40kB)
    100% |████████████████████████████████| 40kB 859kB/s 
Collecting mozversion>=1.3 (from mozregression)
  Downloading mozversion-1.4.tar.gz
Collecting requests<3,>=2.4.3 (from mozregression)
  Downloading requests-2.9.1-py2.py3-none-any.whl (501kB)
    100% |████████████████████████████████| 503kB 238kB/s 
Collecting redo (from mozregression)
  Downloading redo-1.5-py2.py3-none-any.whl
Collecting mozdevice>=0.47 (from mozregression)
  Downloading mozdevice-0.48.tar.gz (64kB)
    100% |████████████████████████████████| 65kB 267kB/s 
Collecting taskcluster>=0.0.32 (from mozregression)
  Downloading taskcluster-0.0.32.tar.gz
Collecting colorama (from mozregression)
  Downloading colorama-0.3.6-py2.py3-none-any.whl
Collecting configobj (from mozregression)
  Downloading configobj-5.0.6.tar.gz
Collecting mozprocess>=0.22 (from mozrunner>=6.11->mozregression)
  Downloading mozprocess-0.22.tar.gz
Collecting blessings>=1.3 (from mozlog>=3.0->mozregression)
  Downloading blessings-1.6.tar.gz
Collecting moznetwork>=0.24 (from mozdevice>=0.47->mozregression)
  Downloading moznetwork-0.27.tar.gz
Collecting PyHawk-with-a-single-extra-commit==0.1.5 (from taskcluster>=0.0.32->mozregression)
  Downloading PyHawk-with-a-single-extra-commit-0.1.5.tar.gz
Collecting slugid (from taskcluster>=0.0.32->mozregression)
  Downloading slugid-1.0.7.tar.gz
Collecting six (from configobj->mozregression)
  Downloading six-1.10.0-py2.py3-none-any.whl
Installing collected packages: mozfile, blessings, mozlog, mozprofile, mozinfo, moznetwork, mozprocess, mozdevice, mozrunner, BeautifulSoup, mozinstall, mozversion, requests, redo, PyHawk-with-a-single-extra-commit, slugid, taskcluster, colorama, six, configobj, mozregression
  Running setup.py install for mozfile
  Running setup.py install for blessings
  Running setup.py install for mozlog
  Running setup.py install for mozprofile
  Running setup.py install for mozinfo
  Running setup.py install for moznetwork
  Running setup.py install for mozprocess
  Running setup.py install for mozdevice
  Running setup.py install for mozrunner
  Running setup.py install for BeautifulSoup
  Running setup.py install for mozinstall
  Running setup.py install for mozversion
  Running setup.py install for PyHawk-with-a-single-extra-commit
  Running setup.py install for slugid
  Running setup.py install for taskcluster
  Running setup.py install for configobj
  Running setup.py install for mozregression
Successfully installed BeautifulSoup-3.2.1 PyHawk-with-a-single-extra-commit-0.1.5 blessings-1.6 colorama-0.3.6 configobj-5.0.6 mozdevice-0.48 mozfile-1.2 mozinfo-0.9 mozinstall-1.12 mozlog-3.1 moznetwork-0.27 mozprocess-0.22 mozprofile-0.28 mozregression-2.3.0 mozrunner-6.11 mozversion-1.4 redo-1.5 requests-2.9.1 six-1.10.0 slugid-1.0.7 taskcluster-0.0.32
You are using pip version 7.1.2, however version 8.0.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
Ed-Wiesmeiers-MacBook:~ ediii$ 

am i good to go?

Comment 17

[Loic]

It should be good, did you try "mozregression --good=43"?

Comment 18

[ed.wiesmeier3]

ok so here's what i did:

Ed-Wiesmeiers-MacBook:~ ediii$ mozregression --good=43
**********
You should use a config file. Please use the --write-config command line flag to help you create one.
**********

 0:00.30 INFO: No 'bad' option specified, using 2016-02-13
 0:00.30 INFO: Using date 2015-09-21 for release 43
 0:06.50 INFO: Testing good and bad builds to ensure that they are really good and bad...
 0:06.50 INFO: Downloading build from: https://archive.mozilla.org/pub/firefox/nightly/2015/09/2015-09-21-07-34-55-mozilla-central/firefox-44.0a1.en-US.mac.dmg
===== Downloaded 100% =====
 3:26.08 INFO: Running mozilla-central build for 2015-09-21
 4:07.30 INFO: Launching /private/var/folders/85/853QBkpBHtekpixHzEsTZk+++TI/-Tmp-/tmp4M1T1N/FirefoxNightly.app/Contents/MacOS/firefox
 4:07.53 INFO: application_buildid: 20150921073455
 4:07.53 INFO: application_changeset: 039a8490891595736b16a3ccb17f025f4dcf13eb
 4:07.53 INFO: application_name: Firefox
 4:07.54 INFO: application_repository: https://hg.mozilla.org/mozilla-central
 4:07.54 INFO: application_version: 44.0a1
Was this nightly build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry' or 'exit' and press Enter): good

nightly fired up 44.0a1 and it works fine so i'm about to hit enter in terminal to indicate "good"

Comment 19

[Loic]

Yes, for each build downloaded, you make the test with your PDF, and you enter "good" or "bad" following the result.
At the end, you should get a pushlog like https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=63cc176d76a66b1807ea4b9500651063032123b1&tochange=d24b11e4beb29e7b0941121b93b10fc155c53a4e

That's this pushlog we want.

Comment 20

[ed.wiesmeier3]

this is the result of the second round 47.0a1

12:00.76 INFO: Using local file: /var/folders/85/853QBkpBHtekpixHzEsTZk+++TI/-Tmp-/tmppzoW7X/2016-02-13--mozilla-central--firefox-47.0a1.en-US.mac.dmg (downloaded in background)
12:00.76 INFO: Running mozilla-central build for 2016-02-13
12:54.05 INFO: Launching /private/var/folders/85/853QBkpBHtekpixHzEsTZk+++TI/-Tmp-/tmpbdxLTf/FirefoxNightly.app/Contents/MacOS/firefox
12:54.32 INFO: application_buildid: 20160213030210
12:54.32 INFO: application_changeset: d719ac4bcbec13e0ba13a41547788e3bf365c679
12:54.32 INFO: application_name: Firefox
12:54.32 INFO: application_repository: https://hg.mozilla.org/mozilla-central
12:54.32 INFO: application_version: 47.0a1
Was this nightly build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry' or 'exit' and press Enter): bad

i'm about to enter "bad" (pdf's and google maps are still garbled) - how will i know when i'm done?

Comment 21

[Loic]

It works by dichotomy so at the end, you get the range when there is no more build to test in that range.
Each time, the range is divided by 2, so it's pretty fast. Anyway, the tool will tell you when it's finished.

No need to copy here the result of each build, run the test and paste only the final pushlog.

Comment 22

[ed.wiesmeier3]

is the pushlog something i cut and paste from the monitor or is it a file i have to find and send?

Comment 23

[Loic]

copy/paste from the console to Firefox.

Comment 24

[ed.wiesmeier3]

this is the latest - now waiting for another download ...

65:04.59 INFO: Got as far as we can go bisecting nightlies...
65:04.59 INFO: Last good revision: bf2bc1aa78c0b72d9b6b13f7a8c6ae61c60a51dc (2015-09-24)
65:04.59 INFO: First bad revision: e5effeb8e57ceddf679f7784faab0c2cebb1e1e6 (2015-09-25)
65:04.59 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bf2bc1aa78c0b72d9b6b13f7a8c6ae61c60a51dc&tochange=e5effeb8e57ceddf679f7784faab0c2cebb1e1e6

65:04.59 INFO: Switching bisection method to taskcluster
65:04.59 INFO: Getting mozilla-central builds between bf2bc1aa78c0b72d9b6b13f7a8c6ae61c60a51dc and e5effeb8e57ceddf679f7784faab0c2cebb1e1e6
65:09.79 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bf2bc1aa78c0b72d9b6b13f7a8c6ae61c60a51dc&tochange=e5effeb8e57ceddf679f7784faab0c2cebb1e1e6

65:09.82 INFO: Downloading build from: https://queue.taskcluster.net/v1/task/t-4y8Xb6TwC0lUNUw-tlqw/runs/0/artifacts/public%2Fbuild%2Ffirefox-44.0a1.en-US.mac.dmg
===

Comment 25

[Loic]

Its the "mid" pushlog from the repository mozilla-central, mozreg will test mozilla-inbound now to continue to reduce it.

Comment 26

[ed.wiesmeier3]

not done yet but got a warning i thought might be interesting:

94:55.17 INFO: Downloading build from: https://queue.taskcluster.net/v1/task/uX5Jw59bQcSIpiQActj7hw/runs/0/artifacts/public%2Fbuild%2Ffirefox-44.0a1.en-US.mac.dmg
===== Downloaded 100% =====
97:19.56 INFO: Running mozilla-inbound build built on 2015-09-23 23:41:57.837000, revision e6dddf80
97:24.29 WARNING: Skipping build 1704ade10932: Unable to find build info using the taskcluster route 'buildbot.revisions.1704ade10932c90e0030130860b59ced9b306068.mozilla-inbound.macosx64'
97:59.61 INFO: Launching /private/var/folders/85/853QBkpBHtekpixHzEsTZk+++TI/-Tmp-/tmp63gdjy/Nightly.app/Contents/MacOS/firefox
97:59.66 INFO: application_buildid: 20150923152016
97:59.67 INFO: application_changeset: e6dddf8043e893f0e3fe886da46e56dddb2d7fef
97:59.67 INFO: application_name: Firefox
97:59.67 INFO: application_repository: https://hg.mozilla.org/integration/mozilla-inbound
97:59.67 INFO: application_version: 44.0a1
Was this inbound build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', 'back' or 'exit' and press Enter):

Comment 27

[ed.wiesmeier3]

another warning:

101:17.56 INFO: Downloading build from: https://queue.taskcluster.net/v1/task/R2AAnLGXTBOEdCbMawEOYQ/runs/0/artifacts/public%2Fbuild%2Ffirefox-44.0a1.en-US.mac.dmg
===== Downloaded 100% =====
102:57.97 INFO: Running mozilla-inbound build built on 2015-09-24 02:29:21.536000, revision 91657db2
102:59.87 WARNING: Skipping build 2c77e4edc2a5: Unable to find build info using the taskcluster route 'buildbot.revisions.2c77e4edc2a55facff5faa192180aa7b6d887129.mozilla-inbound.macosx64'
103:42.25 INFO: Launching /private/var/folders/85/853QBkpBHtekpixHzEsTZk+++TI/-Tmp-/tmpMaqU0N/Nightly.app/Contents/MacOS/firefox
103:42.56 INFO: application_buildid: 20150923175816
103:42.56 INFO: application_changeset: 91657db26f49f885f2338cb8c9302cdf18999f1f
103:42.56 INFO: application_name: Firefox
103:42.57 INFO: application_repository: https://hg.mozilla.org/integration/mozilla-inbound
103:42.57 INFO: application_version: 44.0a1
Was this inbound build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', 'back' or 'exit' and press Enter):

Comment 28

[ed.wiesmeier3]

all done:

114:25.49 INFO: Oh noes, no (more) inbound revisions :(
114:25.50 INFO: Last good revision: e5746165c704a82fc92d059ef9303562d6b3c886
114:25.50 INFO: First bad revision: 5ed72fdd632767e03d6862efd10fc15a34256845
114:25.50 INFO: Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e5746165c704a82fc92d059ef9303562d6b3c886&tochange=5ed72fdd632767e03d6862efd10fc15a34256845

Ed-Wiesmeiers-MacBook:~ ediii$

Comment 29

[Loic]

Ty fr the regression range!
Related to SkiaGL for canvas on OSX.

I guess QA needs to find a machine to try to reproduce the issue, I saw a similar report on the French community board.

Comment 30

[Matt Woodrow (:mattwoodrow)]

Lee, do you have time to look at this?

Comment 31

[Sylvestre Ledru [:Sylvestre]]

Tracking because it is an ugly visual regression!

Comment 32

[William Kenyon]

You guys are way beyond me, but your screenshot captures the problem.  I am running OSX 10.7.5

Comment 33

[Lee Salzman [:lsalzman]]

(In reply to Matt Woodrow (:mattwoodrow) from comment #30)
> Lee, do you have time to look at this?

We'd need to track down someone who can reproduce/debug the issue, since there is no clear "event" hear like a crash with a stacktrace to debug by proxy. I can't get the problem to reproduce on my setup, unfortunately.

Comment 34

[Lee Salzman [:lsalzman]]

Given bug 1246633, it is conceivable we might have to disable SkiaGL for OS X <= 10.7, since it looks like we're not doing too well against the GL drivers there...

Comment 35

[ovidiu boca[:Ovidiu]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #11)

> Rares, maybe someone on the SV team has 10.6 hardware to test on too?

Hi Ryan, unfortunately we don't have the specific OS(MacBook 4,1 OSX 10.6).
I have tested on:

 iMac OS X 10.6 with Firefox 44.0.2 and Firefox Nightly(2016-02-17) 47.0a1 
 MacBook Pro Retina 15 inch 2013 OS X 10.9 with Firefox 44.0.2 and Firefox Nightly(2016-02-17) 47.0a1 

I can't reproduce the issue.

Comment 36

[ed.wiesmeier3]

would it help for me to give you remote access to my macbook?

Comment 37

[Mason Chang [Inactive] [:mchang]]

Can you try these things:

1) Create a new profile
2) go to about:config
3) Set the preference "gfx.canvas.azure.accelerated" to false.
4) Restart Firefox
5) Try a pdf again. Does the issue still occur?

Thanks!

Comment 38

[ed.wiesmeier3]

the issue does not occur - you fixed it :0)

the whole "create a new profile" thing was a nightmare however ...

Comment 39

[Mason Chang [Inactive] [:mchang]]

(In reply to ed.wiesmeier3 from comment #38)
> the issue does not occur - you fixed it :0)
> 
> the whole "create a new profile" thing was a nightmare however ...

Sorry it was such a hassle :(

Can you please try this build - https://archive.mozilla.org/pub/firefox/try-builds/[e-mail]-c265b06eb45998a28f6810152852520aff6dc47a/try-macosx64/firefox-47.0a1.en-US.mac.dmg

Also reenable gfx.canvas.azure.accelerated to true. This should fix it without a new profile!

Thanks!

Comment 40

[ed.wiesmeier3]

it works now regardless of the state of the gfx.canvas... switch - i assume that you have overridden it to be always false in the case of osx10.6?

Comment 41

[Mason Chang [Inactive] [:mchang]]

(In reply to ed.wiesmeier3 from comment #40)
> it works now regardless of the state of the gfx.canvas... switch - i assume
> that you have overridden it to be always false in the case of osx10.6?

Actually there was a bug where it shouldn't have been running on anything higher than 10.7, but that check wasn't actually being done. Thanks a lot for testing!

From comment 40, resolving duplicate of bug 1249312.

Comment 42

[Mason Chang [Inactive] [:mchang]]

Err sorry, we shouldn't have enabled accelerated canvas on anything lower than 10.7.

Comment 43

[Mason Chang [Inactive] [:mchang]]

Just want to confirm, has this been resolved for you on nightly?

Comment 44

[ed.wiesmeier3]

yes - nothing has changed since my response on 2016-02-18 15:42:45 PST

Comment 45

[Liz Henry (:lizzard) (relman/hg->git project)]

Fixed in 46+ in the duplicate. This still affects 45 but I'm untracking it here since it's tracked in bug 1249312.