1244647 - "Share this page" button doesn't open its popup due to ReferenceError: DOMParser is not defined in microformat-shiv.js

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

STR:

1. Launch latest Nightly build
2. Open a web page
3. Click "Share this page" button in the toolbar

Expected Result:

Open popup to choose SNS.

Actual Result:

Popup isn't opened. I see this error in Browser Console at clicking the button:
> ReferenceError: DOMParser is not defined1 microformat-shiv.js:2421:17

This must be a recent regression (I can reproduce this even in safe mode).

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The error line is here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/microformats/microformat-shiv.js?mark=2421-2421#2412

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Oh, I realized that this may depend on the web page.

I cannot reproduce this with a tab open this page. But I can reproduce this with twitter.com, top page of mxr for mozilla-central.

Comment 3

[Alice0775 White]

Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=62b2d7cabf94a62d5fea1836eb50f7e813dff8c1&tochange=96f4549cab327edecf945365a6c2637caef1eecf

Comment 4

[Mark Banner (:standard8)]

We're also seeing this with Hello's "Launch new window" button that we currently use in e10s mode. It may also happen in other areas of Hello, but I haven't found anywhere yet.

NI to Shane as he landed what appears to be the regression point.

Comment 5

[Shane Caraveo (:mixedpuppy)]

looking into this.

Comment 6

[Shane Caraveo (:mixedpuppy)]

Attachment: fix typeof check

I couldn't replicate the hello breakage, but this fixes share.

Comment 7

[alex_mayorga]

¡Hola Shane!

FWIW I found the Hello bug on Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:47.0) Gecko/20100101 Firefox/47.0 ID:20160201030241 CSet: 941033a51983ddec2d99aa9f868a54c0196a4075

Steps:
- Click "Firefox Hello" icon in the tool bar.
- Click "Launch New Window" white on blue button

Expected result:
A new window with e10s disabled and "Firefox Hello" appears.

Actual result:
This shows into the "Browser Console":

    ReferenceError: DOMParser is not defined microformat-shiv.js:2421:17
    ReferenceError: DOMParser is not defined microformat-shiv.js:2421:17
    ReferenceError: DOMParser is not defined microformat-shiv.js:2421:17
    TypeError: metadata is undefined panel.js:1029:9

¡Gracias!

Comment 8

[Shane Caraveo (:mixedpuppy)]

(In reply to Shane Caraveo (:mixedpuppy) from comment #6)
> Created attachment 8714406 [details] [diff] [review]
> fix typeof check
> 
> I couldn't replicate the hello breakage, but this fixes share.

to add some clarity, this patch fixes the problem with DOMParser in microformat-shiv.  I was able to test against share, hello appeared to work just fine.

Comment 9

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8714406 [details] [diff] [review]
fix typeof check

alternate reviewer perhaps...

Comment 10

[Mike de Boer [:mikedeboer]]

Comment on attachment 8714406 [details] [diff] [review]
fix typeof check

Review of attachment 8714406 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the fix, Shane!

::: toolkit/components/microformats/microformat-shiv.js
@@ +2409,5 @@
>  		 *
>           * @return {Object || undefined}
>  		 */
>          getDOMParser: function () {
> +            if (typeof DOMParser === "undefined") {

gosh, this made me smirk a little... just a little.

@@ +4539,5 @@
>      
>      return External;
>      
>      
> +}));

Were these \r's? :-S

Comment 11

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/integration/fx-team/rev/3ab3891c0e98f72af839ecbf758bb8508169f81c
Bug 1244647 fix typeof check, r=mikedeboer

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ab3891c0e98