1244712 - Text flow (word wrap) not working after zoom in

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Toolbar, enhancement)

Description

[石庭豐 (Seak, Teng-Fong)]

Attachment: Text flow (word wrap) testing page

Firefox for Android does not wrap words (ie it has text flow issue) correctly when zooming in.  Example page is attached.

I'll upload four more screen shots to show the issue.

Comment 1

[石庭豐 (Seak, Teng-Fong)]

Attachment: Test web page as shown inside HTC stock browser (without any zoom)

Test web page as shown inside HTC stock browser (without any zoom)
Everything is fine.

Comment 2

[石庭豐 (Seak, Teng-Fong)]

Attachment: Test web page zoomed in inside HTC stock browser

Test web page zoomed in inside HTC stock browser
Notice that word wrap is working correctly.

Comment 3

[石庭豐 (Seak, Teng-Fong)]

Attachment: Test web page as shown inside FF mobile browser (without any zoom)

Test web page as shown inside FF mobile browser (without any zoom)
Everything is fine.

Comment 4

[石庭豐 (Seak, Teng-Fong)]

Attachment: Test web page zoomed in inside FF mobile browser

When we zoom in (using the fingers) the test page inside FF mobile browser, word wrap does NOT work.
Notice that right part of every line is hidden on the screen.
Users have to move screen content in order to read correctly.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

This is a feature that we had at some point in the past but it never worked very well and had performance issues. The person working in it also left and the feature ended up getting disabled. It's not likely that we will reimplement this anytime soon but if somebody volunteers to submit patches for it and maintain it, we would probably take them as it would be a useful feature to have.

Comment 6

[石庭豐 (Seak, Teng-Fong)]

NB: Google Chrome is unable to wrap words either.  HTC stock browser is one of the rare browser which is able to do so, hence, the screen shots.

Comment 7

[Kevin Brosnan [Ex-Mozilla]]

I am not sure that we would take a patch. bug 1049063 was the decision to not fix the feature when it broke 2 years ago. bug 1059014 was removal of most of the code around 3 months ago.

Comment 8

[Botond Ballo [:botond]]

(In reply to Kevin Brosnan [:kbrosnan] from comment #7)
> I am not sure that we would take a patch. bug 1049063 was the decision to
> not fix the feature when it broke 2 years ago. bug 1059014 was removal of
> most of the code around 3 months ago.

My interpretation of those decisions was that we (MoCo staff / Fennec team) felt we didn't have the resources to fix and maintain the code. If, as Kats supposed, someone else volunteered to do so, is there a reason to reject it?

As a user, I would really like to see this behaviour in a mobile browser.

Comment 9

[Kevin Brosnan [Ex-Mozilla]]

The bar would be quite high. It would need to not have the performance issues that the previous implementation had. There is also the maintenance of the code to consider. It is a cool feature, but it is a nice to have.

Comment 10

[karlacio]

The lack of text wrap after zoom is what prevents me to use Firefox as my default browser on Android.
Still nobody interested on this issue after so long time?
Thanks.

Comment 11

[hawran]

(In reply to karlacio from comment #10)
> The lack of text wrap after zoom is what prevents me to use Firefox as my
> default browser on Android.
> Still nobody interested on this issue after so long time?
> Thanks.

Agree.
The lack of this functionality is really a shame.

Comment 12

[hawran]

(In reply to hawran from comment #11)
> (In reply to karlacio from comment #10)
> > The lack of text wrap after zoom is what prevents me to use Firefox as my
> > default browser on Android.
> > Still nobody interested on this issue after so long time?
> > Thanks.
> 
> Agree.
> The lack of this functionality is really a shame.

PS: https://bugzilla.mozilla.org/show_bug.cgi?id=1389788

Comment 13

[Botond Ballo [:botond]]

"Toolbar" doesn't seem like the right component for this, though I'm not sure what's a better one.

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #5)
> This is a feature that we had at some point in the past but it never worked
> very well and had performance issues. The person working in it also left and
> the feature ended up getting disabled.

It's been a while, can you remind me what is the feature that we had? Was it a settings option to have pinch gestures perform full-zoom instead of pinch-zoom?

Comment 14

[Kartikaya Gupta (email:[e-mail])]

(In reply to Botond Ballo [:botond] from comment #13)
> It's been a while, can you remind me what is the feature that we had? Was it
> a settings option to have pinch gestures perform full-zoom instead of
> pinch-zoom?

No, it would do pinch zoom, but then we would reflow with a maximum width restriction on line boxes, so that the text would wrap to the visible screen area. That was the stuff that Scott had worked on, but I think it's basically been removed from the tree at this point.

Comment 15

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.