Closed
Bug 1244758
Opened 9 years ago
Closed 9 years ago
Rename nsAutoTArray to AutoTArray in Mailnews due to bug 1235261 (bustage fix)
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 47.0
People
(Reporter: jorgk-bmo, Assigned: philip.chee)
Details
Attachments
(1 file)
20.16 KB,
patch
|
jorgk-bmo
:
review+
jorgk-bmo
:
feedback+
|
Details | Diff | Splinter Review |
Let's get prepared for the bustage coming due to bug 1235261, attachment 8702132 [details] [diff] [review].
This should be a straight string replacement.
![]() |
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8714342 -
Flags: feedback?(mozilla)
Reporter | ||
Comment 2•9 years ago
|
||
Comment on attachment 8714342 [details] [diff] [review]
Rename nsAutoTArray to AutoTArray
Good, but the causing bug hasn't landed yet ;-)
Can you please paste the script you've used so we can re-run it if necessary.
Attachment #8714342 -
Flags: feedback?(mozilla) → feedback+
![]() |
Assignee | |
Comment 3•9 years ago
|
||
Script? What script. UltraEdit has a GUI to search and replace in files.
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Reporter | ||
Comment 4•9 years ago
|
||
(In reply to Philip Chee from comment #3)
> Script? What script. UltraEdit has a GUI to search and replace in files.
That's not cheap ;-( The poor man's solution would be:
find . -name *.cpp -exec sed -i -e 's/nsAutoTArray/AutoTArray/g' {} \;
Reporter | ||
Comment 5•9 years ago
|
||
Bug 1235261 landed again on inbound.
Reporter | ||
Comment 6•9 years ago
|
||
Comment on attachment 8714342 [details] [diff] [review]
Rename nsAutoTArray to AutoTArray
Review of attachment 8714342 [details] [diff] [review]:
-----------------------------------------------------------------
This is a straight text replacement, so I feel very capable to review this. We might need to land this quickly since bug 1235261 has landed again on M-C inbound (after being backed out once).
rs=jorgk.
Attachment #8714342 -
Flags: review+
Comment 7•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/ff1c31aa974c1258071b523e748fdc3a1b685c4f
Bug 1244758 - Rename nsAutoTArray to AutoTArray following bug 1235261. rs=bustage-fix on CLOSED TREE
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 47.0
You need to log in
before you can comment on or make changes to this bug.
Description
•