1244818 - Icaljs failure on first day of the month | TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:calendar/test/unit/test_alarmservice.js

Status: RESOLVED WORKSFORME

(Calendar :: ICAL.js Integration, defect)

Description

[Stefan Sitter [:ssitter]]

TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:calendar/test/unit/test_alarmservice.js
https://treeherder.mozilla.org/logviewer.html#?job_id=22848&repo=comm-aurora

This test case fails sporadically for icaljs but not for libical. 
Failure seems to happen if test is executed on the first day of the month.

I can reproduce this on Windows by setting the date before running the test:
date: Sun Jan 31 19:12:31 GMT 2016    -> test pass
date: Mon Feb  1 19:13:38 GMT 2016    -> test fail
date: Tue Feb  2 19:15:13 GMT 2016    -> test pass

date: Mon Feb 29 19:16:23 GMT 2016    -> test pass
date: Tue Mar  1 19:17:26 GMT 2016    -> test fail
date: Wed Mar  2 19:19:21 GMT 2016    -> test pass

Comment 1

[Intermittent Failures Robot]

23 automation job failures were associated with this bug yesterday.

Repository breakdown:
* comm-aurora: 13
* comm-beta: 10

Platform breakdown:
* osx-10-6: 5
* osx-10-10: 5
* windowsxp: 4
* windows7-32: 4
* linux64: 4
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1244818&startday=2016-02-01&endday=2016-02-01&tree=all

Comment 2

[Matthew Mecca [:mmecca]]

One of the items used in the test is a monthly repeating event, it fails with ical.js when the system date is the first of the month due to Bug 1103187, one of the incorrect occurrences falls within the alarm service timer range when it shouldn't.

Comment 3

[Intermittent Failures Robot]

71 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* comm-beta: 36
* comm-aurora: 35

Platform breakdown:
* windowsxp: 13
* windows7-32: 13
* osx-10-6: 13
* osx-10-10: 13
* linux64: 13
* linux32: 6

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1244818&startday=2016-02-01&endday=2016-02-07&tree=all

Comment 4

[ISHIKAWA, Chiaki]

I think I am seeing this today.

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&selectedJob=22089
TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:calendar/test/unit/test_alarmservice.js | xpcshell return code: 0
1239148 Permanent debug test_alarmservice.js | xpcshell return code: 1 | application crashed [@ js::TypeFailure(JSContext *,char const *,...)]
1261688 libical failure on first day of the month | TEST-UNEXPECTED-FAIL | xpcshell-libical.ini:calendar/test/unit/test_alarmservice.js
    1244818 Icaljs failure on first day of the month | TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:calendar/test/unit/test_alarmservice.js

TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:calendar/test/unit/test_alarmservice.js | test_addItems - [test_addItems : 12] false == true
1239148 Permanent debug test_alarmservice.js | xpcshell return code: 1 | application crashed [@ js::TypeFailure(JSContext *,char const *,...)]
1261688 libical failure on first day of the month | TEST-UNEXPECTED-FAIL | xpcshell-libical.ini:calendar/test/unit/test_alarmservice.js
    1244818 Icaljs failure on first day of the month | TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:calendar/test/unit/test_alarmservice.js

TEST-UNEXPECTED-FAIL | xpcshell-libical.ini:calendar/test/unit/test_alarmservice.js | xpcshell return code: 0

1239148 Permanent debug test_alarmservice.js | xpcshell return code: 1 | application crashed [@ js::TypeFailure(JSContext *,char const *,...)]
1261688 libical failure on first day of the month | TEST-UNEXPECTED-FAIL | xpcshell-libical.ini:calendar/test/unit/test_alarmservice.js

    1244818 Icaljs failure on first day of the month | TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:calendar/test/unit/test_alarmservice.js

TEST-UNEXPECTED-FAIL | xpcshell-libical.ini:calendar/test/unit/test_alarmservice.js | test_addItems - [test_addItems : 12] false == true

1239148 Permanent debug test_alarmservice.js | xpcshell return code: 1 | application crashed [@ js::TypeFailure(JSContext *,char const *,...)]
1261688 libical failure on first day of the month | TEST-UNEXPECTED-FAIL | xpcshell-libical.ini:calendar/test/unit/test_alarmservice.js
1244818 Icaljs failure on first day of the month | TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:calendar/test/unit/test_alarmservice.js

Comment 5

[Intermittent Failures Robot]

7 failures in 694 pushes (0.01 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* comm-central: 7

Platform breakdown:
* windows7-32: 2
* linux64: 2
* linux32: 2
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1244818&startday=2016-11-28&endday=2016-12-04&tree=all

Comment 6

[Decathlon]

Attachment: patch - v1

All the logs show an error in the test "addTestItems Test 7" that had to be fixed with the patch for bug 1261688 but seems that the sequence of alarm status for the 1st of December is wrong.

I re-tested again the test for the first day of every month by changing date/time on my OS and all the months works fine. I hope that all the sequences are right this time.

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8817027 [details] [diff] [review]
patch - v1

Review of attachment 8817027 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, let us try it!

Comment 8

[Decathlon]

I've waited for the first day of a new month to run a test on the try server:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=61eaceb5a0ec4181ff8bfcb97a727f5a91facd13

Now we get an error on the test "addTestItems Test 6" that is different from those ones reported in comment 5 ("addTestItems Test 7") that occurred also with libical.

This is caused by a daily recurrence test:
https://dxr.mozilla.org/comm-central/source/calendar/test/unit/test_alarmservice.js#229
and probably is the original issue because it occurs only with ical.js (when this bug was opened, it was very hard to distinguish the test that failed because there weren't informative messages).

Comment 9

[Decathlon]

Attachment: patch - v2

Currently I can reproduce, locally, only on the 1st of December and 1st of January of every year.

As mentioned above, the issue on the 1st of January concerns only icaljs about the test "addTestItems Test 6".
As far as I can see, this case depends on the automatic normalization of the date. The function createEventWithAlarm() uses a date that has not (completely) updated after the hour has been changed:
https://dxr.mozilla.org/comm-central/source/calendar/test/unit/test_alarmservice.js#230

Adding a code line that reads the attribute "hour" causes a call to the "get" method which completes (or starts) the normalization:
https://dxr.mozilla.org/comm-central/source/calendar/base/modules/ical.js#5635

This patch includes the previous one so it fixes the issues on both the dates (verified locally).


I wouldn't know how to do a different fix without changing the way the normalization works in icaljs. What's your opinion Philipp?

Comment 10

[Decathlon]

Attachment: patch - v3

I've eliminated the fix required for the failure on the 1st of December because I've included it in the patch for bug 1352148 that changes a bit that part of the code.
In this patch there's only the fix for the failure caused by icaljs.

Comment 11

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8854182 [details] [diff] [review]
patch - v3

Review of attachment 8854182 [details] [diff] [review]:
-----------------------------------------------------------------

Is there another way to force normalization, or can we fix something in the wrapper instead that would avoid us having to add this hack?

Comment 12

[Philipp Kewisch [:Fallen][📱📆]]

Ah I see you already thought about that in the comment before. I will see if I can find out a solution.

Comment 13

[Intermittent Failures Robot]

2 failures in 462 pushes (0.004 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* comm-central: 2

Platform breakdown:
* windows7-32: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1244818&startday=2018-01-01&endday=2018-01-07&tree=all

Comment 14

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8854182 [details] [diff] [review]
patch - v3

Review of attachment 8854182 [details] [diff] [review]:
-----------------------------------------------------------------

It doesn't look like I'm going to find time to work on a different solution for the time being, but of course it would be great to get this bug fixed. To set expectations I'm removing the review flag, if you happen to come up with something I'm happy to review a bit quicker next time!

Comment 15

[Jorg K (CEST = GMT+2)]

How come this went perma-red just now?

Comment 16

[Geoff Lankow (:darktrojan)]

Check the date and the summary of this bug.

Comment 17

[Jorg K (CEST = GMT+2)]

Oh, the 1st of the month thing. Did we not fix that ages ago? I see, this has a long history, see bug 1352148 comment #6 which refers to this bug here. But why didn't it fail on the 1st Dec 2019:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=7dcc5e7050596410102eb42e30fdf1003e3477d8
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=8c2f8de771068d5bc849a4e1c5c33329f1e7ea01
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=a0470cab33c08920a9b7644048e36144ce05d396

I don't want to scroll back to the 1st Nov 2019, but I can't remember seeing this bug in a while.

Comment 18

[Intermittent Failures Robot]

20 failures in 119 pushes (0.168 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 20

Platform breakdown:

• macosx1014-64: 4
• linux64: 4
• linux32: 4
• windows7-32: 4
• windows10-64: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1244818&startday=2020-01-01&endday=2020-01-01&tree=all

Comment 19

[Intermittent Failures Robot]

16 failures in 403 pushes (0.04 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 15
• comm-beta: 1

Platform breakdown:

• linux64: 2
• linux32: 2
• macosx1014-64: 2
• linux64-shippable: 2
• macosx1014-64-shippable: 1
• linux32-shippable: 1
• windows10-64: 2
• windows7-32: 2
• windows10-64-shippable: 1
• windows7-32-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1244818&startday=2020-01-02&endday=2020-01-02&tree=all

Comment 20

[Magnus Melin [:mkmelin]]

Paul, please have a look at resolving this at some point.

Comment 21

[Intermittent Failures Robot]

41 failures in 1862 pushes (0.022 failures/push) were associated with this bug in the last 7 days.

This is the #10 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 40
• comm-beta: 1

Platform breakdown:

• linux64-shippable: 3
• linux32-shippable: 2
• macosx1014-64-shippable: 2
• windows10-64-shippable: 2
• windows7-32-shippable: 2
• macosx1014-64: 6
• linux64: 6
• linux32: 6
• windows7-32: 6
• windows10-64: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1244818&startday=2019-12-30&endday=2020-01-05&tree=all

Comment 22

[Magnus Melin [:mkmelin]]

Possibly related: https://github.com/mozilla-comm/ical.js/pull/232, bug 1266797

Comment 23

[Intermittent Failures Robot]

13 failures in 525 pushes (0.025 failures/push) were associated with this bug in the last 7 days.

This is the #37 most frequent failure this week.

Repository breakdown:

• comm-central: 13

Platform breakdown:

• linux64: 2
• windows10-64: 1
• windows7-32: 3
• macosx1014-64: 3
• linux64-shippable: 1
• macosx1014-64-shippable: 1
• windows7-32-shippable: 1
• windows10-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1244818&startday=2020-12-28&endday=2021-01-03&tree=all

Comment 24

[Intermittent Failures Robot]

1 failures in 3263 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux1804-64-tsan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1244818&startday=2021-12-13&endday=2021-12-19&tree=all

Comment 25

[Intermittent Failures Robot]

2 failures in 3165 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform and build breakdown:

• macosx1015-64-qr: 1
  • debug: 1
• windows10-64-2004-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1244818&startday=2022-01-31&endday=2022-02-06&tree=all

Comment 26

[Magnus Melin [:mkmelin]]

Happened again Jan 1 2023. Maybe it's just 1.1 now...

Comment 27

[Intermittent Failures Robot]

12 failures in 2607 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 12

Platform and build breakdown:

• macosx1015-64-qr: 2
  • opt: 1
  • debug: 1
• linux1804-64-shippable-qr: 1
  • opt: 1
• linux1804-64-qr: 2
  • debug: 1
  • opt: 1
• windows10-64-2004-shippable-qr: 1
  • opt: 1
• windows10-32-2004-shippable-qr: 1
  • opt: 1
• windows10-32-2004-qr: 2
  • debug: 1
  • opt: 1
• windows10-64-2004-qr: 2
  • opt: 1
  • debug: 1
• macosx1015-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1244818&startday=2023-01-02&endday=2023-01-08&tree=all

Comment 28

[Magnus Melin [:mkmelin]]

Happens this year as well (no surprise).
I can confirm the attach patch would fix it. It might be reasonable to take it as it seems it could be a test bug for the most part.
There is similar "normalization" here: https://searchfox.org/comm-central/rev/4deb3ffcf75305d3eb5c326e588317efe2508564/calendar/base/modules/Ical.jsm#7848

Comment 29

[Intermittent Failures Robot]

16 failures in 401 pushes (0.04 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 16

Platform and build breakdown:

• windows11-32-2009-qr: 2
  • debug: 1
  • opt: 1
• macosx1015-64-qr: 1
  • opt: 1
• linux1804-64-qr: 2
  • debug: 1
  • opt: 1
• windows11-64-2009-qr: 4
  • debug: 2
  • opt: 2
• linux1804-64-shippable-qr: 1
  • opt: 1
• windows11-32-2009-shippable-qr: 1
  • opt: 1
• windows11-64-2009-shippable-qr: 2
  • opt: 2
• linux1804-64-ccov-qr: 1
  • opt: 1
• macosx1015-64-shippable-qr: 1
  • opt: 1
• windows11-64-2009-ccov-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1244818&startday=2024-01-02&endday=2024-01-02&tree=all

Comment 30

[Intermittent Failures Robot]

16 failures in 2274 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 16

Platform and build breakdown:

• windows11-32-2009-qr: 2
  • debug: 1
  • opt: 1
• macosx1015-64-qr: 1
  • opt: 1
• linux1804-64-qr: 2
  • debug: 1
  • opt: 1
• windows11-64-2009-qr: 4
  • debug: 2
  • opt: 2
• linux1804-64-shippable-qr: 1
  • opt: 1
• windows11-32-2009-shippable-qr: 1
  • opt: 1
• windows11-64-2009-shippable-qr: 2
  • opt: 2
• linux1804-64-ccov-qr: 1
  • opt: 1
• macosx1015-64-shippable-qr: 1
  • opt: 1
• windows11-64-2009-ccov-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1244818&startday=2024-01-01&endday=2024-01-07&tree=all

Comment 31

[Geoff Lankow (:darktrojan)]

Mass closure of all bugs in the Calendar, MailNews Core, and Thunderbird components with the "intermittent-failure" keyword and no activity in the last six months.