No plugin name and version annotations on plugin crashes with e10s turned on

RESOLVED FIXED

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kairo, Assigned: jimm)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(e10sm9+)

Details

Comment 1

3 years ago
Agree this is pretty important.

These annotations are written here: http://hg.mozilla.org/mozilla-central/annotate/5f9ba76eb3b1/dom/plugins/ipc/PluginModuleParent.cpp#l836

I'd expect PluginModuleChromeParent::WriteExtraDataForMinidump to be the codepath for both chrome and plugin crashes. Bill am I wrong about that class being used (in the chrome process) in the e10s case?
Flags: needinfo?(wmccloskey)
(Assignee)

Comment 2

3 years ago
something wee need for crash analysis.
Assignee: nobody → wmccloskey
tracking-e10s: ? → m9+
Flags: needinfo?(wmccloskey)
Blocks: 1251376
(Assignee)

Updated

3 years ago
Assignee: wmccloskey → jmathies
(Assignee)

Comment 3

3 years ago
I just tested this in a local mc build and the annotations are getting set properly.

https://crash-stats.mozilla.com/report/index/a009eb6d-01e9-4743-b82a-41fe42160317
(Assignee)

Comment 5

3 years ago
I knew this code looked familiar! Fixed by bug 1256943.

http://hg.mozilla.org/mozilla-central/rev/3c8ea88e6916
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.