1245225 - [e10s] Fix and/or re-enable test cases in toolkit/components/thumbnails/test/

Status: RESOLVED FIXED

(Toolkit :: General, defect, P2)

Description

[Tracy Walker [:tracy]]

Filing this bug to track work of getting all the thumbnail test cases enabled and working.

The following are currently working and just need to have skip-if e10s removed form the broswer.ini file.  Try run for those passes. The thumbnails set of tests is run in bc5. https://treeherder.mozilla.org/#/jobs?repo=try&revision=8604c8ea25f3

browser_thumbnails_bg_crash_during_capture.js
browser_thumbnails_bg_crash_while_idle.js
browser_thumbnails_bg_no_cookies_sent.js
browser_thumbnails_bug727765.js
browser_thumbnails_capture.js

browser fixes are required for:
browser_thumbnails_redirect.js which depends on bug 1050869 and
browser_thumbnails_update.js which depends on bug 1245118

Comment 1

[Tracy Walker [:tracy]]

Attachment: thumbnails_browser_ini.patch

Patch to re-enable 5 test cases passes try, per previous comment.

Comment 2

[Tracy Walker [:tracy]]

Please leave open for work on the remaining two test cases in this test directory, both of which depend on toolkit code work.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/69ec780e039c

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

A bunch of these newly re-enabled tests immediately started failing. Backed this out in https://hg.mozilla.org/integration/fx-team/rev/8b22e807786d

https://treeherder.mozilla.org/logviewer.html#?job_id=7053855&repo=fx-team

Comment 5

[Tracy Walker [:tracy]]

hmmm, three failures in the one test file of toolkit/components/thumbnails/test/browser_thumbnails_bg_crash_during_capture.js on Mac 10.10 opt

Passed try and passes locally for me on 10.9.5.  Maybe there is something in fx-team that breaks this test?  I guess I'll wait a few days 'til it's on m-c and try again.  If it doesn't appear locally, all I can do is provide a new patch that skip-ifs that test for e10s on Mac.

Comment 6

[Tracy Walker [:tracy]]

the test case in question, toolkit/components/thumbnails/test/browser_thumbnails_bg_crash_during_capture.js, is now failing for me locally in same manner as the backout cause.  Failures are intermittent, locally, I'll investigate.  

However, I'll also post a new patch, today, for re-enabling the other tests that are working fine.

Comment 7

[Tracy Walker [:tracy]]

Attachment: thumbnails_browser_ini-2.patch

jimm, it turns out browser_thumbnails_bg_crash_during_capture.js is an intermittent failing test case.  I'm investigating it, but would like to get the other four testcases re-enabled. I ran each of them several times again locally and they all pass. They also passed on fx-team in the first attempt to land them.

Comment 8

[Jim Mathies [:jimm]]

(In reply to [:tracy] Tracy Walker from comment #7)
> Created attachment 8716332 [details] [diff] [review]
> thumbnails_browser_ini-2.patch
> 
> jimm, it turns out browser_thumbnails_bg_crash_during_capture.js is an
> intermittent failing test case.  I'm investigating it, but would like to get
> the other four testcases re-enabled. I ran each of them several times again
> locally and they all pass. They also passed on fx-team in the first attempt
> to land them.

can you post a link to a failure log?

Comment 9

[Tracy Walker [:tracy]]

Here's a link to the raw fx-team log: http://mozilla-releng-blobs.s3.amazonaws.com/blobs/fx-team/sha512/b969dd979d7111b8076cdb1f44f4d55d3f1d83e8412aad98d53ae3fc88396c52754e2b5f3aff592a5b8a34af3a54f950d32edf783d0e1861e6c7a0147c0bae7c

Here's a link to the error summary: https://treeherder.mozilla.org/logviewer.html#?job_id=7053855&repo=fx-team

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ed1086f28ad1

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ed1086f28ad1

Comment 12

[Justin Dolske [:Dolske]]

(In reply to Tracy Walker [:tracy] from comment #0)

> browser fixes are required for:
> browser_thumbnails_redirect.js which depends on bug 1050869 and
> browser_thumbnails_update.js which depends on bug 1245118

I just updated the dependency field for the first bug (a digit was transposed, so it was pointing to an unrelated bug). Coincidentally, the correct bug 1050869 just got closed WFM today. Can you see if this test is now working?

There's also a 3rd test disabled in E10S, from comment 7 (browser_thumbnails_bg_crash_during_capture.js).

Are you still looking at this? It's one of the few remaining front-end E10S tests still disabled.

Comment 13

[Tracy Walker [:tracy]]

browser_thumbnails_redirect.js and browser_thumbnails_update.js are both still failing locally.

browser_thumbnails_bg_crash_during_capture.js is working, but it's listed as investigate for intermittent failures. I wasn't able to determine why it is intermittent.  Requires someone with more advanced skills than my own to investigate.

Comment 14

[Chris Peterson [:cpeterson]]

Justin, can you find someone to take a look at re-enabling these thumbnails tests for e10s?

Comment 15

[Justin Dolske [:Dolske]]

Drew's familiar with this, over to him.

Comment 16

[Drew Willcoxon :adw]

browser_thumbnails_bg_crash_during_capture.js is the only remaining test.  I filed bug 1294509 for it.  Hopefully the patch I have now fixes it.

Comment 17

[Drew Willcoxon :adw]

OK, all these tests are enabled on e10s on m-c now.  Sorry it took me so long to get to this.