Test onUpdated with updates while lacking tab permissions

RESOLVED FIXED in Firefox 51

Status

()

Toolkit
WebExtensions: Untriaged
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mattw, Assigned: mattw)

Tracking

unspecified
mozilla51
Points:
---
Bug Flags:
blocking-webextensions +

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: [testing] triaged)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)

Updated

2 years ago
Flags: blocking-webextensions-

Updated

2 years ago
Flags: blocking-webextensions- → blocking-webextensions+
(Assignee)

Updated

2 years ago
Iteration: --- → 47.2 - Feb 22
(Assignee)

Updated

2 years ago
Iteration: 47.2 - Feb 22 → 47.3 - Mar 7
(Assignee)

Updated

2 years ago
Assignee: nobody → mwein
(Assignee)

Updated

2 years ago
Iteration: 47.3 - Mar 7 → 48.1 - Mar 21
(Assignee)

Updated

2 years ago
Iteration: 48.1 - Mar 21 → ---

Updated

2 years ago
Whiteboard: [testing] triaged
(Assignee)

Updated

2 years ago
Iteration: --- → 48.3 - Apr 25
(Assignee)

Comment 1

2 years ago
Created attachment 8743073 [details]
Bug 1245346 Add test for onUpdated while lacking tab permissions

Review commit: https://reviewboard.mozilla.org/r/40125/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40125/
Attachment #8743073 - Flags: review?(kmaglione+bmo)
(Assignee)

Comment 2

2 years ago
Comment on attachment 8743073 [details]
Bug 1245346 Add test for onUpdated while lacking tab permissions

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40125/diff/1-2/
(Assignee)

Comment 3

2 years ago
Comment on attachment 8743073 [details]
Bug 1245346 Add test for onUpdated while lacking tab permissions

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40125/diff/2-3/
Comment on attachment 8743073 [details]
Bug 1245346 Add test for onUpdated while lacking tab permissions

https://reviewboard.mozilla.org/r/40125/#review45249

::: browser/components/extensions/test/browser/browser_ext_tabs_onUpdated.js:176
(Diff revision 3)
>    });
>  });
>  
> +add_task(function* test_without_tabs_permission() {
> +  yield do_test_update(function background() {
> +    browser.tabs.create({url: "about:robots"}, function(tab) {

We should use the same URL as the other test here.
Attachment #8743073 - Flags: review?(kmaglione+bmo) → review+
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 6

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/dc208a4e4258
Add test for onUpdated while lacking tab permissions. r=kmag
Keywords: checkin-needed

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dc208a4e4258
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.