1245346 - Test onUpdated with updates while lacking tab permissions

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Comment 1

[Matthew Wein [:mattw]]

Attachment: Bug 1245346 Add test for onUpdated while lacking tab permissions

Review commit: https://reviewboard.mozilla.org/r/40125/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40125/

Comment 2

[Matthew Wein [:mattw]]

Comment on attachment 8743073 [details]
Bug 1245346 Add test for onUpdated while lacking tab permissions

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40125/diff/1-2/

Comment 3

[Matthew Wein [:mattw]]

Comment on attachment 8743073 [details]
Bug 1245346 Add test for onUpdated while lacking tab permissions

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40125/diff/2-3/

Comment 4

[Kris Maglione [:kmag]]

Comment on attachment 8743073 [details]
Bug 1245346 Add test for onUpdated while lacking tab permissions

https://reviewboard.mozilla.org/r/40125/#review45249

::: browser/components/extensions/test/browser/browser_ext_tabs_onUpdated.js:176
(Diff revision 3)
>    });
>  });
>  
> +add_task(function* test_without_tabs_permission() {
> +  yield do_test_update(function background() {
> +    browser.tabs.create({url: "about:robots"}, function(tab) {

We should use the same URL as the other test here.

Comment 5

[Matthew Wein [:mattw]]

Comment on attachment 8743073 [details]
Bug 1245346 Add test for onUpdated while lacking tab permissions

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40125/diff/3-4/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/dc208a4e4258
Add test for onUpdated while lacking tab permissions. r=kmag

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dc208a4e4258