Closed Bug 1245346 Opened 4 years ago Closed 3 years ago

Test onUpdated with updates while lacking tab permissions

Categories

(WebExtensions :: Untriaged, defect)

defect
Not set

Tracking

(firefox51 fixed)

RESOLVED FIXED
mozilla51
Iteration:
48.3 - Apr 25
Tracking Status
firefox51 --- fixed

People

(Reporter: mattw, Assigned: mattw)

References

Details

(Whiteboard: [testing] triaged)

Attachments

(1 file)

No description provided.
Flags: blocking-webextensions-
Flags: blocking-webextensions- → blocking-webextensions+
Iteration: --- → 47.2 - Feb 22
Iteration: 47.2 - Feb 22 → 47.3 - Mar 7
Assignee: nobody → mwein
Iteration: 47.3 - Mar 7 → 48.1 - Mar 21
Iteration: 48.1 - Mar 21 → ---
Whiteboard: [testing] triaged
Iteration: --- → 48.3 - Apr 25
Comment on attachment 8743073 [details]
Bug 1245346 Add test for onUpdated while lacking tab permissions

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40125/diff/1-2/
Comment on attachment 8743073 [details]
Bug 1245346 Add test for onUpdated while lacking tab permissions

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40125/diff/2-3/
Comment on attachment 8743073 [details]
Bug 1245346 Add test for onUpdated while lacking tab permissions

https://reviewboard.mozilla.org/r/40125/#review45249

::: browser/components/extensions/test/browser/browser_ext_tabs_onUpdated.js:176
(Diff revision 3)
>    });
>  });
>  
> +add_task(function* test_without_tabs_permission() {
> +  yield do_test_update(function background() {
> +    browser.tabs.create({url: "about:robots"}, function(tab) {

We should use the same URL as the other test here.
Attachment #8743073 - Flags: review?(kmaglione+bmo) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/dc208a4e4258
Add test for onUpdated while lacking tab permissions. r=kmag
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/dc208a4e4258
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.