1245426 - gaia-switch, gaia-radio and gaia-checkbox support enter key event

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Sean Lee [:seanlee][:weilonge]]

Since TV product (bug 1242314) needs a settings app to configure some settings, e.g. WiFi, BT, the original phone design is a good fundamental app to implement a TV one.

gaia-switch, gaia-radio and gaia-checkbox are the components need to support key navigation feature in the porting task, so this issue is to discuss how to support the Enter key for these components.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] weilonge:seanlee/GaiaComponents/master/Bug1245426 > mozilla-b2g:master

Comment 2

[Sean Lee [:seanlee][:weilonge]]

In attachment 8715220 [details] [review], gaia-switch, gaia-radio and gaia-checkbox support toggling behavior when Enter Key is pressed at the focus components.

Comment 3

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8715220 [details] [review]
[gaia] weilonge:seanlee/GaiaComponents/master/Bug1245426 > mozilla-b2g:master

Hey Kevin,

Key navigation is an important mechanism for TV product due to lack of pointer devices. When Enter key event is sent to these elements (gaia-switch, gaia-checkbox, gaia-radio), the state of the elements should be changed as well.
This patch includes the key handling logic to change the state.

Could you help to review my patch? Thank you.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8715220 [details] [review]
[gaia] weilonge:seanlee/GaiaComponents/master/Bug1245426 > mozilla-b2g:master

This seems fine to me, thanks!

Comment 5

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/761dcd47c81a0e444868c2b54b5641c0a45a4431