1245470 - mingw-w64 compiled Firefox breaks with EMET (Tor 13893)

Status: RESOLVED WORKSFORME

(Core :: XPCOM, defect, P3)

Description

[Georg Koppen]

Compiling Firefox with mingw-w64 is broken if one is using Microsoft's EMET (https://support.microsoft.com/en-us/kb/2458544). EMET detects SimExecFlow mitigation and closes Firefox.

This, however, does not happen if one is using --disable-optimize for compilation. It seems EMET does not like the optimized created by GCC.

There is further information available starting with https://trac.torproject.org/projects/tor/ticket/13893#comment:16.

Comment 1

[Georg Koppen]

Might actually be as simple as doing the same as bug 1233208 for AvailableMemoryTracker, in case this is the right fix?

Comment 2

[Benjamin Smedberg]

I don't think that mingw is considered an important compiler target for the Mozilla project: we're focusing much of our Windows effort on clang-cl as a free alternative to MSVC. I'm happy to leave this bug open if you're planning on fixing it, otherwise I suggest we close INCOMPLETE.

Comment 3

[Georg Koppen]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> I don't think that mingw is considered an important compiler target for the
> Mozilla project: we're focusing much of our Windows effort on clang-cl as a
> free alternative to MSVC. I'm happy to leave this bug open if you're
> planning on fixing it, otherwise I suggest we close INCOMPLETE.

Yes, we plan to work on it.

Comment 4

[Georg Koppen]

I think we can close the Mozilla side of this issue (i.e. this ticket). bug 1201205 helped a lot and the remaining things go away if one switches to GCC 6. So this is strictly speaking WORKSFORME from a Mozilla PoV.