1245530 - Remove usages of Cu.import(Services.jsm) in favor or require("Services")

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Alexandre Poirot [:ochameau]]

Today, we mix both Cu.import and require for loading Services.
This is disturbing. Either we consider that require("Services") is really useful and use it everywhere, or we stick with Cu.import(). But we shouldn't have both in our codebase.

Comment 1

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee1182bc4287

Comment 2

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=23068cb42858

Comment 3

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=633f590780fd

Comment 4

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef118d4303e1

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: patch v1

Let's try to wrap up with this refactoring patch I keep rebasing...

Comment 6

[Alexandre Poirot [:ochameau]]

Comment on attachment 8722927 [details] [diff] [review]
patch v1

Review of attachment 8722927 [details] [diff] [review]:
-----------------------------------------------------------------

This is a quite dump patch...
Sometimes I have to move around the precise line where I do a require(), as require is often available a few lines after.
Sometimes I already replace lazyImporter with require() as there isn't much value in lazy loading this module!

Comment 7

[Alexandre Poirot [:ochameau]]

Here is a try build with this patch (and many others)
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=848118726eaa&exclusion_profile=false

Comment 8

[Alexandre Poirot [:ochameau]]

Even greener try, with even more patches:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=6989b13865cb

Comment 9

[Alexandre Poirot [:ochameau]]

Attachment: patch v2

Rebased.

Comment 10

[Alexandre Poirot [:ochameau]]

https://hg.mozilla.org/integration/fx-team/rev/93f0d5522db1bcdb8a7c839930025a2d2f37b443
Bug 1245530 - Use require(Services) instead of Cu.import(Services.jsm). r=jryans

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/93f0d5522db1