1252346 - Services is missing from various modules

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Somehow this was only revealed when I tried to re-run the unhandled promise rejection patch...

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Seems like it was never there...?  I am pretty confused about this one.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1252346 - Some DevTools files missing Services. r=ochameau

Review commit: https://reviewboard.mozilla.org/r/37335/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37335/

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 8725081 [details]
MozReview Request: Bug 1252346 - Some DevTools files missing Services. r=ochameau

https://reviewboard.mozilla.org/r/37335/#review33903

I'm not surprised, with what I'm seeing all over our codebase :-o

window may not be used that much. it is only used in isMultiProcess getter in target.js.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Fixes missing Services definition or tweaked eslint to figure out where does it comes from.

Comment 5

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5945112f6bc1

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8725324 [details] [diff] [review]
Fixes missing Services definition or tweaked eslint to figure out where does it comes from.

Review of attachment 8725324 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/jsonview/test/doc_frame_script.js
@@ +3,5 @@
>   http://creativecommons.org/publicdomain/zero/1.0/ */
>  
>  "use strict";
>  
> +/* globals Services,sendAsyncMessage,addMessageListener */

Nit: I think people usually put spaces between, so ", "

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8725081 [details]
MozReview Request: Bug 1252346 - Some DevTools files missing Services. r=ochameau

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37335/diff/1-2/

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Updated my patch with a few more that didn't appear in :ochameau's.  Hopefully if we land both, we'll be pretty good.

Comment 9

[Alexandre Poirot [:ochameau]]

Attachment: Fixes missing Services definition or tweaked eslint to figure out where does it comes from.

With spaces.

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

They both seem safe to land, going to push both.  Hopefully that's okay!

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/50130647c697
https://hg.mozilla.org/integration/fx-team/rev/a88b9e9d747a

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/50130647c697
https://hg.mozilla.org/mozilla-central/rev/a88b9e9d747a