Closed Bug 1252346 Opened 4 years ago Closed 4 years ago

Services is missing from various modules

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(firefox47 fixed)

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

Details

Attachments

(2 files, 1 obsolete file)

Somehow this was only revealed when I tried to re-run the unhandled promise rejection patch...
Seems like it was never there...?  I am pretty confused about this one.
Comment on attachment 8725081 [details]
MozReview Request: Bug 1252346 - Some DevTools files missing Services. r=ochameau

https://reviewboard.mozilla.org/r/37335/#review33903

I'm not surprised, with what I'm seeing all over our codebase :-o

window may not be used that much. it is only used in isMultiProcess getter in target.js.
Attachment #8725081 - Flags: review?(poirot.alex) → review+
Comment on attachment 8725324 [details] [diff] [review]
Fixes missing Services definition or tweaked eslint to figure out where does it comes from.

Review of attachment 8725324 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/jsonview/test/doc_frame_script.js
@@ +3,5 @@
>   http://creativecommons.org/publicdomain/zero/1.0/ */
>  
>  "use strict";
>  
> +/* globals Services,sendAsyncMessage,addMessageListener */

Nit: I think people usually put spaces between, so ", "
Attachment #8725324 - Flags: review?(jryans) → review+
Comment on attachment 8725081 [details]
MozReview Request: Bug 1252346 - Some DevTools files missing Services. r=ochameau

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37335/diff/1-2/
Attachment #8725081 - Attachment description: MozReview Request: Bug 1252346 - target.js is missing Services. r=ochameau → MozReview Request: Bug 1252346 - Some DevTools files missing Services. r=ochameau
Updated my patch with a few more that didn't appear in :ochameau's.  Hopefully if we land both, we'll be pretty good.
Summary: Services is missing from target.js → Services is missing from various modules
Attachment #8725324 - Attachment is obsolete: true
They both seem safe to land, going to push both.  Hopefully that's okay!
https://hg.mozilla.org/mozilla-central/rev/50130647c697
https://hg.mozilla.org/mozilla-central/rev/a88b9e9d747a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.