Closed
Bug 1245717
Opened 8 years ago
Closed 7 years ago
Temporarily installed add-on not distinguished
Categories
(DevTools :: about:debugging, defect, P3)
Tracking
(firefox54 fixed)
RESOLVED
FIXED
Firefox 54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: andy+bugzilla, Assigned: mstriemer)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(4 files)
A temporary installed add-on in about:debugging looks exactly the same as an normally installed add-on in about:debugging. Except one of them will go away when you restart Firefox. Would be nice if we can re-use styles from about:addons, but cc'ing Markus for advice there.
Comment 1•8 years ago
|
||
How different is the relevance of temporary installed add-ons? Would they deserve to be the first entries of the list, or a separate grouping? Or is it only about a small notification, kind of a footnote? Best if Bram includes such consideration in his work on the Add-on Dev experience.
Flags: needinfo?(bram)
Comment 2•8 years ago
|
||
What do you think about repurposing the warning we use for unverified add-on? The difference is, this warning will show both when you enable and disable the add-on. We can say something like “[addon_name] is installed temporarily and will be removed when you restart Firefox.” What do you think?
Flags: needinfo?(bram)
Comment 3•8 years ago
|
||
Alex, is this something you'd be interested in taking on / mentoring?
Flags: needinfo?(poirot.alex)
Priority: -- → P3
Updated•8 years ago
|
Flags: needinfo?(poirot.alex)
Comment 5•8 years ago
|
||
I guess bug 1273184 will be a first step toward distinguishing temporary add-ons.
Updated•8 years ago
|
Keywords: dev-doc-needed
Comment 6•8 years ago
|
||
Yep, the patch in bug 1269889 introduces a boolean property `addon.temporarilyInstalled` and the patch in bug 1273184 exposes it to the about:debugging React components.
Assignee | ||
Comment 7•7 years ago
|
||
The about:addons styles appear to have changed and that warning is no longer there. It doesn't seem to indicate that an extension is temporarily loaded at all.
Assignee | ||
Comment 8•7 years ago
|
||
I feel there was some discussion about this on vidyo at some point and we wanted to break out the temporary add-ons into their own area since they are more likely to be interacted with by the developer. I mocked up what this might look like in about:debugging broken out into its own area up top. Is this what we'd like to see or should they be sorted along with the other extensions? Should I add some sort of explanation of what a "temporary extension" is, mentioning that it will be removed on restart or is that self-evident by the naming?
Flags: needinfo?(mjaritz)
Flags: needinfo?(bram)
Assignee | ||
Updated•7 years ago
|
Assignee: kumar.mcmillan → mstriemer
Assignee | ||
Comment 9•7 years ago
|
||
Never mind about the question of breaking this out. I missed the invisionapp link in the PRD.
Flags: needinfo?(mjaritz)
Flags: needinfo?(bram)
Comment hidden (mozreview-request) |
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8843165 [details] Bug 1245717 - List temporary add-ons separately in about:debugging https://reviewboard.mozilla.org/r/116924/#review118618 Thanks for this, looks good! R+ with a green try. ::: devtools/client/aboutdebugging/test/head.js:374 (Diff revision 1) > name, > isWebExtension: true, > }); > > // Retrieve the DEBUG button for the addon > - let names = [...document.querySelectorAll("#addons .target-name")]; > + let names = getInstalledAddonNames(document); Thanks for mutualizing this! ::: devtools/client/locales/en-US/aboutdebugging.properties:64 (Diff revision 1) > > # LOCALIZATION NOTE (extensions): > # This string is displayed as a header above the list of loaded add-ons. > extensions = Extensions > > +# LOCALIZATION NOTE (temporary-extensions): temporary-extensions -> temporaryExtensions (should match the key exactly)
Attachment #8843165 -
Flags: review?(jdescottes) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 13•7 years ago
|
||
(In reply to Julian Descottes [:jdescottes] from comment #11) > Thanks for this, looks good! R+ with a green try. I submitted this try build [1] last night before updating the localisation comment. It looks like the only failures are attached to intermittents but I don't really know how to parse this, or know if I ran the right stuff. Is that good enough? [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=c25f2c2e6a0aa42d1864d199e006be26cc565d21&selectedJob=81337673
Assignee | ||
Comment 14•7 years ago
|
||
Luca said he took a look at the try build and the failures look unrelated. Marking checkin-needed.
Keywords: checkin-needed
Comment 15•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/19ef442244e2 List temporary add-ons separately in about:debugging r=jdescottes
Keywords: checkin-needed
Comment 16•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/19ef442244e2
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment 17•7 years ago
|
||
I have reproduced this bug with Nightly 47.0a1 (2016-02-03) on Windows 10, 64 bit! The bug's fix is now verified on Latest Beta 54.0b3 Build ID 20170427091925 User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0 [bugday-20170426]
Comment 18•7 years ago
|
||
Docs update here: https://developer.mozilla.org/en-US/docs/Tools/about:debugging
Updated•7 years ago
|
Keywords: dev-doc-needed → dev-doc-complete
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•