1246281 - Various animation inspector devtools mochitests are going to permafail when Gecko 47 merges to Beta

Status: RESOLVED FIXED

(DevTools :: Inspector: Animations, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Merge day permafail when Gecko 47 merges to Beta.

Relying on a feature that's ifdef !RELEASE_BUILD?

https://treeherder.mozilla.org/logviewer.html#?job_id=16411251&repo=try

 10:58:06     INFO -  746 INFO TEST-UNEXPECTED-FAIL | devtools/server/tests/browser/browser_animation_emitMutations.js | uncaught exception - TypeError: document.querySelector(...).animate is not a function at http://test1.example.org/browser/devtools/server/tests/browser/animation.html:182
 10:58:06     INFO -  Stack trace:
 10:58:06     INFO -  chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1525
 10:58:06     INFO -  JavaScript error: http://test1.example.org/browser/devtools/server/tests/browser/animation.html, line 182: TypeError: document.querySelector(...).animate is not a function

Comment 1

[Patrick Brosset <:pbro>]

Brian: What's our story with element.animate() right now? When will it be released?
I've added a new test in 47 that uses it in order to test animation.id, but it's failing in beta simulations because element.animate seems to be disabled there.

Comment 2

[Brian Birtles (:birtles)]

(In reply to Patrick Brosset [:pbrosset] [:pbro] from comment #1)
> Brian: What's our story with element.animate() right now? When will it be
> released?
> I've added a new test in 47 that uses it in order to test animation.id, but
> it's failing in beta simulations because element.animate seems to be
> disabled there.

I'm planning on introducing a new pref for Element.animate in bug 1245000. Element.animate should be available if any of the following are true: (a) that pref is true, (b) the existing pref (dom.animations-api.core.enabled) is true, or (c) the caller is chrome.

If we succeed in fixing all the blockers for bug 1245000 in the 47 timeframe (and I hope we will) and there is no opposition when I send an intent to ship, then I plan to switch that new pref on by default in 47.

Comment 3

[Patrick Brosset <:pbro>]

(In reply to Brian Birtles (:birtles, away 9 Feb) from comment #2)
> I'm planning on introducing a new pref for Element.animate in bug 1245000.
> Element.animate should be available if any of the following are true: (a)
> that pref is true, (b) the existing pref (dom.animations-api.core.enabled)
> is true, or (c) the caller is chrome.
> 
> If we succeed in fixing all the blockers for bug 1245000 in the 47 timeframe
> (and I hope we will) and there is no opposition when I send an intent to
> ship, then I plan to switch that new pref on by default in 47.
Thanks Brian. In the case of this test, the caller isn't chrome. We could set that pref to true when the test starts though.

Comment 4

[Patrick Brosset <:pbro>]

Hmm, maybe we won't need to care in fact. I'm working on bug 1245849 in parallel and in that bug, I might actually delete the file that uses element.animate.

Comment 5

[Patrick Brosset <:pbro>]

Bug 1245849 just landed, and in it, I eliminated the culprit that caused a lot of tests to fail on beta.
So this bug becomes invalid now (or works for me, ...).

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Or fixed by bug 1245849 :P

Thanks, Patrick!