Hello toolbar button icon shadow is clipped on some edges

RESOLVED FIXED

Status

Hello (Loop)
Client
P1
minor
Rank:
9
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: MattN, Assigned: dcritch)

Tracking

({regression})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [btpp-fix-now][fixed by bug 1257672], URL)

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Created attachment 8716538 [details]
Mozreview comparison

mozscreenshots[1] detected a change in the Hello toolbar icon on today's Nightly (2016-02-05) whereby the left, top and right of the toolbar button shadow/outline seems ever so slightly clipped. It seemed to only be detected with a dark theme.

See the comparison at https://reviewboard.mozilla.org/r/33857/file/187-189/

Comparison between the Nightlies: http://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=f2f8fc172f4c&newProject=mozilla-central&newRev=1dbe350b57b1

[1] https://github.com/mnoorenberghe/mozscreenshots
Duplicate of this bug: 1246511
Rank: 10
Priority: -- → P1
(In reply to Matthew N. [:MattN] from comment #0)
> It seemed to only be detected with a dark theme.

This is *particularly* noticeable if you have a "dark theme" that has a colorful background (rather than a black or gray background) -- sample screenshot: attachment 1246511.

(In the dark lightweight theme screenshots at screenshots.mattn.ca URL in comment 0, this bug is harder to see, because the icon's cropped border just blends into the black/gray background around it.)
(er, not sure why my "attachment 1246511" text wasn't linkified. Anyway, that screenshot is https://bugzilla.mozilla.org/attachment.cgi?id=8716793 )
Whiteboard: [btpp-fix-now]
Assignee: nobody → standard8
Duplicate of this bug: 1248810

Updated

a year ago
Blocks: 1248604

Updated

a year ago
Rank: 10 → 19
Sevaan, please can we get 16x16 / 32x32 versions of all the toolbar icons.

We could do with them fairly quickly as the buttons we're currently broken in the inverted icons case (xref bug 1257672 comment 3).

Although we could just get the inverted ones done, the non-inverted ones also are based around 18x18, and I think it would be good to just get them all resized correctly now.

Our current versions are under in https://github.com/mozilla/loop/tree/master/add-on/chrome/skin
Flags: needinfo?(sfranks)

Updated

a year ago
Blocks: 1258335
No longer blocks: 1248604

Updated

a year ago
Rank: 19 → 9
Created attachment 8732886 [details]
Toolbar Assets

Please let me know if these work, thanks!
Flags: needinfo?(sfranks)
This is being fixed by bug 1257672 which should land today, so I'll mark it as fixed now.
Assignee: standard8 → dcritchley
Status: NEW → RESOLVED
Last Resolved: a year ago
Depends on: 1257672
Resolution: --- → FIXED
Whiteboard: [btpp-fix-now] → [btpp-fix-now][fixed by bug 1257672]

Comment 8

a year ago
Not fixed for me. Build 2016-04-02
(In reply to Charles Milette from comment #8)
> Not fixed for me. Build 2016-04-02

This is not in nightly builds yet. It has landed in our special loop repository, but hasn't moved across to mozilla-* yet.
You need to log in before you can comment on or make changes to this bug.