1246422 - [gtk3] not using system colors for depressed/hovered button text and menubar selected text (e.g. HighContrast)

Status: NEW

(Core :: Widget: Gtk, defect, P4)

Description

[Mack]

Attachment: Menu as it's supposed to appear (from FF 44 without GTK3 enabled)

there are some UI elements which don't use system colors correctly in GTK3 ...

the menu buttons (e.g. "File", "Edit", etc.) don't use the system color for selected text (that is, their text doesn't change colors as applicable when selected). this is particularly problematic when the selected background color is close to the unselected text color. see attached screen captures ... menu-good.png (FF 44 without GTK3 enabled) and menu-bad.png (FF 45 Beta with GTK3 enabled). only affects the menu buttons themselves, not the items within each menu.

there are some buttons (for example in the Page Info window, but in other places, too) that exhibit the same problem when the mouse is hovered over them. see attached screen captures ... button-good.png (FF 44 without GTK3 enabled) and button-bad.png (FF 45 Beta with GTK3 enabled).

Comment 1

[Mack]

Attachment: Menu showing problem (from FF 45 Beta with GTK3 enabled)

Comment 2

[Mack]

Attachment: Button as it's supposed to appear (from FF 44 without GTK3 enabled)

Comment 3

[Mack]

Attachment: Button showing problem (from FF 45 Beta with GTK3 enabled)

Comment 4

[:Gijs (he/him)]

Seems we're about to ship this. Karl, do we know what's going on here?

Comment 5

[Karl Tomlinson (:karlt)]

The GTK3 version of Firefox is likely to look different from the GTK2 version if the GTK themes for GTK2 and GTK3 look different.

However, if buttons and menus in Firefox are looking different from those in other GTK3 apps, then there is a bug to fix here.

Are you able to compare appearance in a different GTK3 please?

I don't know of another GTK3 app using menubars, but gtk3-widget-factory has a hamburger button beside its minimize button and a button to open a font selection dialog labelled something like "Sans Regular" "12".

Can you identify the GTK3 theme involved, please?
(Different desktop environments configure this in different ways.)

Comment 6

[Mack]

buttons and menus in gtk3 Firefox do indeed look different than buttons and menus in other gtk3 applications. I have not seen this problem in any other application.

I will attach screen captures from Gnome Character Map, for comparison.

The gtk3 theme used for the screen captures is "High Contrast", however the same issue applies to all themes which have a different color for selected menu text than for unselected menu text (and which have a different color for hovered button text than for not hovered button text). Examples include "Blue-Submarine" (menu), "DeLorean" (menu), "DeLorean-Dark" (menu), "Green-Submarine" (menu), "High Contrast Inverse" (button), and "TraditionalOk" (menu). Note that the effect isn't as obvious in some of the themes as it is in "High Contrast".

Also note that I used incorrect terminology in my original report in referring to "selected text" color (attaching screen capture to show where I took the terminology). To distinguish, I'm now referring to this as "selected menu text" color and "hovered button text" color, although that may not be the correct theme lingo. Testing showed that the theme's "selected text" color isn't the one that's applicable. The relevant color property is one which is not listed in the "Appearance Preferences" "Customize Theme" "Colors" tab. (I don't know which color property is applicable, but I can probably find out if necessary.)

Comment 7

[Mack]

Attachment: GTK3 application (Gnome Character Map) which does not exhibit menu problem

Comment 8

[Mack]

Attachment: GTK3 application (Gnome Character Map) which does not exhibit button problem

Comment 9

[Mack]

Attachment: theme colors dialog (does not list the applicable theme color property)

Comment 10

[Karl Tomlinson (:karlt)]

Thanks, with HighContrast from gnome-themes-standard 3.16.2 and gtk+ 3.16.7, I can see the text color is not changing when the button is depressed.

This version of HighContrast, however, does not change the text color on button hover or on selected menubar item (even in gucharmap).

Comment 11

[Mack]

Karl, I have the same versions of those packages installed. I'm guessing you are also on Fedora 22. Please see next attachment. There are two themes labeled "High Contrast" in Fedora Mate spin. One of them (the one it seems you used (highlighted in red)) does not seem to be complete, and this bug is not expressed with that version of the theme since that version of the theme doesn't change the text color for button hover or for selected menubar items.

Comment 12

[Mack]

Attachment: Fedora 22 Mate spin has more than one theme labeled "High Contrast"

Comment 13

[Karl Tomlinson (:karlt)]

I'm running Gentoo here and /usr/share/themes/HighContrast/gtk-3.0/gtk.css from gnome-themes-standard actually contains only
"/* HighCOntrast is part of Gtk 3.14, this file is no longer used */".

Comment 14

[Mack]

Karl, for me, the applicable theme is located at /usr/share/themes/ContrastHigh and is provided by the mate-themes package. (If Gentoo does not have this package, you should be able to install from https://github.com/mate-desktop/mate-themes/tree/master/desktop-themes/ContrastHigh)

I was able to determine that the gtk3 color property which Firefox isn't using for the applicable UI elements is the following (for both the selected menubar text and the hovered button text):
theme_selected_fg_color

Comment 15

[Karl Tomlinson (:karlt)]

Thanks.  That's useful info for reproducing.  I'm unlikely to have time to work on this myself though sorry.

Comment 16

[Jeremy M]

I am seeing subtle strange behavior with GTK3 themes Adwaita, and clearlooks-phenix with Firefox. Adwaita shows a transparent selection background (should be white bg). Whereas clearlooks shows black foreground text on the menubar (should be white). It is only the menu bar, navigating down to menu items is correct. This is with FF 44.0.2, x64. Running ArchLinux, so pretty bleeding edge. 

Pretty sure this is related to GTK3, but working on compiling same version of FF with GTK2 to compare.

Comment 17

[Jeremy M]

(In reply to Jeremy M from comment #16)
> I am seeing subtle strange behavior with GTK3 themes Adwaita, and
> clearlooks-phenix with Firefox. Adwaita shows a transparent selection
> background (should be white bg). Whereas clearlooks shows black foreground
> text on the menubar (should be white). It is only the menu bar, navigating
> down to menu items is correct. This is with FF 44.0.2, x64. Running
> ArchLinux, so pretty bleeding edge. 
> 
> Pretty sure this is related to GTK3, but working on compiling same version
> of FF with GTK2 to compare.

Confirmed menu colors are fine compiling with GTK2.

Comment 18

[Turson]

Hi.
How currently is not reported the Bug that GTK3 integration since Firefox 46.0 on Linux Mint (Mate)? Firefox don't take-on the customized colors (ex: Gray windows and input box) for Default themes, ex: gray colors to url and search bar, context menu, main and side panels (history, bookmarks). These remains WHITE curently in Fx 46.0, 47.0.