Closed Bug 1246431 Opened 6 years ago Closed 6 years ago

Only the domain is a required portion of the JID for !muc

Categories

(Chat Core :: XMPP, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Instantbird 47

People

(Reporter: arlolra, Unassigned)

References

Details

Attachments

(1 file)

Attached patch domain.patchSplinter Review
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.103 Safari/537.36

Steps to reproduce:

Sent an unencrypted msg on a server that enforces encryption.


Actual results:

The server responded with a message, that threw!

    Timestamp: ...
    Warning: received:
    <message xmlns="jabber:client" from="jabber.calyxinstitute.org" to="...@jabber.ccc.de/Instantbird" type="chat">
     <body xmlns="jabber:client">
      For security reasons, OTR encryption is required for conversations on this server
     </body>
    </message>

    Source File: resource:///modules/xmpp-xml.jsm
    Line: 325
    Source Code:
    prpl-jabber: XMPPParser.prototype._logReceivedData


Expected results:

Started a conversation with "jabber.calyxinstitute.org" and displayed the message.
Attachment #8716671 - Attachment is patch: true
Attachment #8716671 - Attachment mime type: text/x-patch → text/plain
Attachment #8716671 - Flags: review?(aleth)
Notice `from="jabber.calyxinstitute.org"`.
This is rfc 6120 8.1.2.1.2
Comment on attachment 8716671 [details] [diff] [review]
domain.patch

Review of attachment 8716671 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8716671 - Flags: review?(aleth) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/1759abefc9195a9110c89822fcaf051cd05b0132
Bug 1246431 - XMPP createConversation should handle incoming messages from the server properly. r=aleth
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 47
Duplicate of this bug: 1320511
You need to log in before you can comment on or make changes to this bug.