1246835 - Reduce #ifdefs pain in GMPChild.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect, P2)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

In GMPChild.cpp, GetFileBase() and GetPluginFile() have an aLibDirectory parameter that is only passed on MacOSX. This means all the callsites have to have #ifdefs around them.

We need to extract the directory of the plugin file for the sandbox setup, but I most call sites don't need the extra argument. We can make the code more readable by using polymorphism and removing the ifdefs.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Reduce #ifdefs pain in GMPChild.cpp

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0b8f05a48d564dd81012d4c5e8239dec796c0f6
Bug 1246835 - Reduce #ifdefs pain in GMPChild.cpp. r=gerald

Comment 3

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/35cdc40a44c4

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e328bafd9d8ee7f17b68baf783a25a5979ceb78d
Bug 1246835 - Reduce #ifdefs pain in GMPChild.cpp. r=gerald

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e328bafd9d8e