1246871 - Generate platform.ini with the preprocessor instead of an ad-hoc script

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium] (high latency)]

Attachment: Generate platform.ini with the preprocessor instead of an ad-hoc script

Comment 2

[Mike Hommey [:glandium] (high latency)]

Attachment: Generate platform.ini with the preprocessor instead of an ad-hoc script

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8717354 [details] [diff] [review]
Generate platform.ini with the preprocessor instead of an ad-hoc script

Seems to work fine. Is it safe to rely on the fact that dist/bin/platform.ini gets removed by the install manifest processing in order to force rebuilding it later? You've removed the dependency on config/buildid, and platform.ini.pp doesn't add it in automatically. However, since we're basically re-building this every time anyway, that doesn't strictly matter. If that feature of install manifests changes in the future, then platform.ini might no longer be re-generated properly.

Comment 4

[Mike Hommey [:glandium] (high latency)]

Note that feature of install manifests has already changed, in the faster make backend. But the faster make backend handles preprocessed files /with/ install manifests, so in practice, it works :)

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a186b51bf9ac

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a186b51bf9ac