Closed
Bug 1246871
Opened 4 years ago
Closed 4 years ago
Generate platform.ini with the preprocessor instead of an ad-hoc script
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Not set
Tracking
(firefox47 fixed)
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 1 obsolete file)
5.74 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•4 years ago
|
||
Attachment #8717333 -
Flags: review?(mshal)
Assignee | ||
Comment 2•4 years ago
|
||
Attachment #8717333 -
Attachment is obsolete: true
Attachment #8717333 -
Flags: review?(mshal)
Attachment #8717354 -
Flags: review?(mshal)
Comment 3•4 years ago
|
||
Comment on attachment 8717354 [details] [diff] [review] Generate platform.ini with the preprocessor instead of an ad-hoc script Seems to work fine. Is it safe to rely on the fact that dist/bin/platform.ini gets removed by the install manifest processing in order to force rebuilding it later? You've removed the dependency on config/buildid, and platform.ini.pp doesn't add it in automatically. However, since we're basically re-building this every time anyway, that doesn't strictly matter. If that feature of install manifests changes in the future, then platform.ini might no longer be re-generated properly.
Attachment #8717354 -
Flags: review?(mshal) → review+
Assignee | ||
Comment 4•4 years ago
|
||
Note that feature of install manifests has already changed, in the faster make backend. But the faster make backend handles preprocessed files /with/ install manifests, so in practice, it works :)
Comment 6•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a186b51bf9ac
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Updated•2 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•