Closed Bug 1246871 Opened 4 years ago Closed 4 years ago
.ini with the preprocessor instead of an ad-hoc script
No description provided.
Comment on attachment 8717354 [details] [diff] [review] Generate platform.ini with the preprocessor instead of an ad-hoc script Seems to work fine. Is it safe to rely on the fact that dist/bin/platform.ini gets removed by the install manifest processing in order to force rebuilding it later? You've removed the dependency on config/buildid, and platform.ini.pp doesn't add it in automatically. However, since we're basically re-building this every time anyway, that doesn't strictly matter. If that feature of install manifests changes in the future, then platform.ini might no longer be re-generated properly.
Attachment #8717354 - Flags: review?(mshal) → review+
Note that feature of install manifests has already changed, in the faster make backend. But the faster make backend handles preprocessed files /with/ install manifests, so in practice, it works :)
You need to log in before you can comment on or make changes to this bug.