Closed
Bug 1246874
Opened 9 years ago
Closed 9 years ago
Unify GRE_BUILDID and MOZ_APP_BUILDID at the build system level
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox47 fixed)
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
16.64 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8717329 -
Flags: review?(mshal)
Comment 2•9 years ago
|
||
Comment on attachment 8717329 [details] [diff] [review]
Unify GRE_BUILDID and MOZ_APP_BUILDID at the build system level
>diff --git a/mobile/android/base/AppConstants.java.in b/mobile/android/base/AppConstants.java.in
>+ public static final String MOZ_APP_BUILDID = "@MOZ_BUILDID@";
Is there any reason not to update the java code to use MOZ_BUILDID instead of MOZ_APP_BUILDID as well? Then it'd be easy to see everywhere MOZ_BUILDID is used.
>diff --git a/mobile/android/base/Makefile.in b/mobile/android/base/Makefile.in
>+MOZ_BUILDID=$(shell cat $(DEPTH)/config/buildid)
Can you switch this to := while you're here?
Attachment #8717329 -
Flags: review?(mshal) → review+
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Michael Shal [:mshal] from comment #2)
> Comment on attachment 8717329 [details] [diff] [review]
> Unify GRE_BUILDID and MOZ_APP_BUILDID at the build system level
>
> >diff --git a/mobile/android/base/AppConstants.java.in b/mobile/android/base/AppConstants.java.in
> >+ public static final String MOZ_APP_BUILDID = "@MOZ_BUILDID@";
>
> Is there any reason not to update the java code to use MOZ_BUILDID instead
> of MOZ_APP_BUILDID as well? Then it'd be easy to see everywhere MOZ_BUILDID
> is used.
I didn't want to touch non-build system.
Comment 5•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•