1246874 - Unify GRE_BUILDID and MOZ_APP_BUILDID at the build system level

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Unify GRE_BUILDID and MOZ_APP_BUILDID at the build system level

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8717329 [details] [diff] [review]
Unify GRE_BUILDID and MOZ_APP_BUILDID at the build system level

>diff --git a/mobile/android/base/AppConstants.java.in b/mobile/android/base/AppConstants.java.in
>+    public static final String MOZ_APP_BUILDID = "@MOZ_BUILDID@";

Is there any reason not to update the java code to use MOZ_BUILDID instead of MOZ_APP_BUILDID as well? Then it'd be easy to see everywhere MOZ_BUILDID is used.

>diff --git a/mobile/android/base/Makefile.in b/mobile/android/base/Makefile.in
>+MOZ_BUILDID=$(shell cat $(DEPTH)/config/buildid)

Can you switch this to := while you're here?

Comment 3

[Mike Hommey [:glandium]]

(In reply to Michael Shal [:mshal] from comment #2)
> Comment on attachment 8717329 [details] [diff] [review]
> Unify GRE_BUILDID and MOZ_APP_BUILDID at the build system level
> 
> >diff --git a/mobile/android/base/AppConstants.java.in b/mobile/android/base/AppConstants.java.in
> >+    public static final String MOZ_APP_BUILDID = "@MOZ_BUILDID@";
> 
> Is there any reason not to update the java code to use MOZ_BUILDID instead
> of MOZ_APP_BUILDID as well? Then it'd be easy to see everywhere MOZ_BUILDID
> is used.

I didn't want to touch non-build system.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d315d56d7d5b

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d315d56d7d5b