Closed Bug 1246874 Opened 4 years ago Closed 4 years ago

Unify GRE_BUILDID and MOZ_APP_BUILDID at the build system level

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8717329 [details] [diff] [review]
Unify GRE_BUILDID and MOZ_APP_BUILDID at the build system level

>diff --git a/mobile/android/base/AppConstants.java.in b/mobile/android/base/AppConstants.java.in
>+    public static final String MOZ_APP_BUILDID = "@MOZ_BUILDID@";

Is there any reason not to update the java code to use MOZ_BUILDID instead of MOZ_APP_BUILDID as well? Then it'd be easy to see everywhere MOZ_BUILDID is used.

>diff --git a/mobile/android/base/Makefile.in b/mobile/android/base/Makefile.in
>+MOZ_BUILDID=$(shell cat $(DEPTH)/config/buildid)

Can you switch this to := while you're here?
Attachment #8717329 - Flags: review?(mshal) → review+
(In reply to Michael Shal [:mshal] from comment #2)
> Comment on attachment 8717329 [details] [diff] [review]
> Unify GRE_BUILDID and MOZ_APP_BUILDID at the build system level
> 
> >diff --git a/mobile/android/base/AppConstants.java.in b/mobile/android/base/AppConstants.java.in
> >+    public static final String MOZ_APP_BUILDID = "@MOZ_BUILDID@";
> 
> Is there any reason not to update the java code to use MOZ_BUILDID instead
> of MOZ_APP_BUILDID as well? Then it'd be easy to see everywhere MOZ_BUILDID
> is used.

I didn't want to touch non-build system.
https://hg.mozilla.org/mozilla-central/rev/d315d56d7d5b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Depends on: 1248246
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.