Closed Bug 1247114 Opened 4 years ago Closed 4 years ago
Tabs UI more discoverable
2.77 KB, patch
|Details | Diff | Splinter Review|
2.75 KB, patch
|Details | Diff | Splinter Review|
For users who's profile was created before Firefox 45, the "Synced Tabs" button is likely to be in customize purgatory - we'd like to make it more discoverable for those users. Ryan and I came up with: * If Sync is configured and the button is in purgatory, move it to the panel. * Write a pref once we've done this, so we only make the check once. Even better would be a kind of UITour to explain the feature, but this is tricky to do in a non-invasive way and is significant work. CC Javaun, who also had some thoughts.
Gijs, Hopefully this patch is somewhat obvious, but we want to arrange to move the synced-tabs button to the panel if it is in "customize purgatory", which it almost certainly will be for profiles created before Synced Tabs landed.
Assignee: nobody → markh
Status: NEW → ASSIGNED
Attachment #8718220 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8718220 [details] [diff] [review] 0011-Bug-1247114-do-a-one-off-move-of-the-synced-tabs-but.patch Review of attachment 8718220 [details] [diff] [review]: ----------------------------------------------------------------- rs=me if and only if this rides the same train as the synced tabs button (45). :-\ It's low risk for uplift, but it really should have happened when we landed this, because if we land it a few trains later, it will in some cases put the button back when the user has already moved it back from the panel. We'll have to live with that for nightly and beta and aurora now, but it would be good to avoid it on release. Sorry for not making more noise about this case when I reviewed the original panel patches. :-(
Attachment #8718220 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 8718220 [details] [diff] [review] 0011-Bug-1247114-do-a-one-off-move-of-the-synced-tabs-but.patch This hasn't landed yet, but I'm still requesting approval now - see comment 2 for why. Approval Request Comment [Feature/regressing bug #]: Synced Tabs [User impact if declined]: Existing Firefox users will not have the Synced Tabs button in their panel. [Describe test coverage new/current, TreeHerder]: Existing tests pass. [Risks and why]: A simple patch with low risk, limited to Synced Tabs button. [String/UUID change made/needed]: None
Comment on attachment 8718220 [details] [diff] [review] 0011-Bug-1247114-do-a-one-off-move-of-the-synced-tabs-but.patch Let's take it as it improves a new feature Should be in 45 beta 7
I'm hitting conflicts uplifting this because the patch that was uplifted for bug 1243591 didn't add the block just above what this patch touches in browser-syncui.js. Can we get a rebased patch for it?
Here ya go - thanks! I tested it against Aurora, but I'm confident (ha!) it will apply cleanly to beta too.
Flags: needinfo?(markh) → needinfo?(wkocher)
Attachment #8721148 - Flags: review+
I'm not landing anything tonight. Redirecting the needinfo to tomcat since he'll be online soon. This missed beta7, for the record.
Flags: needinfo?(wkocher) → needinfo?(cbook)
Confirm that “Synced Tabs” button is successfully displayed in Panel Menu after updating from Firefox 44.0.2 to Firefox 47.0a1 (2016-02-22), Firefox 46.0a2 (2016-02-22) and Firefox 45 beta 8 (20160221141421). Tested under Windows 10 64-bit, Ubuntu 12.04 32-bit and Mac OS X 10.9.5.
You need to log in before you can comment on or make changes to this bug.