Closed Bug 1247162 Opened 4 years ago Closed 4 years ago

Generate a header defining MOZ_SOURCE_*

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

No description provided.
The behavior is not entirely idempotent (most notably for
buildconfig.html), but this can be improved later if necessary.
It is idempotent where it matters.

This allows to get rid of config/makefiles/rcs.mk and its uses.

Review commit: https://reviewboard.mozilla.org/r/34395/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34395/
Attachment #8718091 - Flags: review?(mshal)
Comment on attachment 8718091 [details]
MozReview Request: Bug 1247162 - Generate a header defining MOZ_SOURCE_*. r=mshal

https://reviewboard.mozilla.org/r/34395/#review31265

Everything LGTM.
Attachment #8718091 - Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/51029f4d82d3
https://hg.mozilla.org/mozilla-central/rev/c2efabe8fab1
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Depends on: 1267270
Depends on: 1298719
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.