Closed Bug 1247331 Opened 4 years ago Closed 4 years ago

Import snapshot button should be an icon

Categories

(DevTools :: Memory, defect, P2)

defect

Tracking

(firefox50 verified)

VERIFIED FIXED
Firefox 50
Tracking Status
firefox50 --- verified

People

(Reporter: fitzgen, Assigned: hholmes)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 2 obsolete files)

Maybe one of those box-with-arrow-going-in things?

       |
    +- | -+
    |  V  |
    +-----+

Maybe sideways instead of down?

    +---+
    | <---
    +---+

Thoughts?
I see the "down" icon a lot; let's go with that even if sideways makes sense for us in particular.
Assignee: nobody → hholmes
Has STR: --- → irrelevant
Priority: -- → P2
I would rather use an up icon since it's more commonly used for uploading (importing action) while the down icon is used more for downloading (exporting action).
Attached image upload-expanded.svg (obsolete) —
Attached patch import-snapshot.patch (obsolete) — Splinter Review
(In reply to Tim Nguyen :ntim (use needinfo?) from comment #2)
> I would rather use an up icon since it's more commonly used for uploading
> (importing action) while the down icon is used more for downloading
> (exporting action).

So, a quick google search revealed that "upload icon" was an upward pointing arrow pretty much unanimously.

"Import icon" had arrows pointing in all four directions.

So I went with what Tim suggested, since it seemed like it had /slightly/ less ambiguity. Kinda.
Attachment #8770167 - Attachment is obsolete: true
Attachment #8770365 - Flags: review?(ntim.bugs)
Comment on attachment 8770365 [details] [diff] [review]
import-snapshot.patch

Review of attachment 8770365 [details] [diff] [review]:
-----------------------------------------------------------------

The icon looks great! I am seeing the bottom stroke of the import icon a bit blurry, it seems like it's not perfectly pixel snapped. I'll upload a new version as it should be trivial to fix (the bottom edge is apart only from 0.08 pixel from the pixel grid).

Love the new diff icon, perfectly pixel snapped, and matches better the new icon style. Thanks for updating it.

Past that, it seems like the Style Editor and the Canvas tools have an import button, can you change these to use the new icon ?
Attachment #8770365 - Flags: review?(ntim.bugs) → feedback+
(In reply to Tim Nguyen :ntim (use needinfo?) from comment #5)
> I'll upload a new
> version as it should be trivial to fix (the bottom edge is apart only from
> 0.08 pixel from the pixel grid).
Added!

> Past that, it seems like the Style Editor and the Canvas tools have an
> import button, can you change these to use the new icon ?
Added these as well. Wasn't sure if /where/ I added the rules in the CSS makes sense—since you're more familiar with the CSS in general, can you advise if there's a better place for those rules to live?
Attachment #8770365 - Attachment is obsolete: true
Attachment #8770676 - Flags: review?(ntim.bugs)
Comment on attachment 8770676 [details] [diff] [review]
upload-icon.patch

Review of attachment 8770676 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! I'll land this with my comment applied, and bug 1260523 with it as well.

::: devtools/client/themes/styleeditor.css
@@ +12,5 @@
> +}
> +
> +.style-editor-importButton .toolbarbutton-text {
> +  display: none;
> +}

it seems like both of these rules are not needed (.toolbarbutton-icon and .toolbarbutton-text)
Attachment #8770676 - Flags: review?(ntim.bugs) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/006a4f4e6852
Make import snapshot an icon,r=ntim
https://hg.mozilla.org/mozilla-central/rev/006a4f4e6852
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Depends on: 1287094
I've managed this issue on this bug in Nightly 47.0a1 (2016-02-10) ; (Build ID: 20160210071115) from Linux, 64 Bit.

This Bug is now verified as fixed on Latest Firefox Nightly 50.0a1 (2016-07-21) 

Build ID: 20160721030216 
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
QA Whiteboard: [bugday-20160720]
Status: RESOLVED → VERIFIED
No longer depends on: 1287094
Depends on: 1293594
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.