Closed Bug 1247470 Opened 6 years ago Closed 6 years ago
Bouncer APK packaging breaks Android l10n single repacks
MozReview Request: Bug 1247470 - Don't try to sign bouncer APK during Android single locale repacks. r?glandium
58 bytes, text/x-review-board-request
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Component: General → Build Config & IDE Support
There's no slick way to determine that we're doing a single local repack, and it's not worth adding a new flag just for this situation. So let's not sign the bouncer APK if tests are disabled; since tests are disabled during single local repack packaging, this should be sufficient. This makes the bouncer APK just like the Robocop APK. Review commit: https://reviewboard.mozilla.org/r/34431/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/34431/
Attachment #8718199 - Flags: review?(mh+mozilla)
Attachment #8718199 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8718199 [details] MozReview Request: Bug 1247470 - Don't try to sign bouncer APK during Android single locale repacks. r?glandium https://reviewboard.mozilla.org/r/34431/#review31357 ::: toolkit/mozapps/installer/upload-files.mk:341 (Diff revision 1) > +INNER_INSTALL_BOUNCER_PACKAGE=echo If you use true instead of echo, you won't add an empty line to the log.
This might be fixed, hard to tell as the l10n nightlies fail to find tooltool.py, filed bug 1248255 on that.
See Also: → 1248255
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 47 → mozilla47
You need to log in before you can comment on or make changes to this bug.