1247470 - Bouncer APK packaging breaks Android l10n single repacks

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Nick Alexander :nalexander [he/him]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1234629#c50.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1247470 - Don't try to sign bouncer APK during Android single locale repacks. r?glandium

There's no slick way to determine that we're doing a single local
repack, and it's not worth adding a new flag just for this situation.
So let's not sign the bouncer APK if tests are disabled; since tests
are disabled during single local repack packaging, this should be
sufficient.  This makes the bouncer APK just like the Robocop APK.

Review commit: https://reviewboard.mozilla.org/r/34431/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34431/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8718199 [details]
MozReview Request: Bug 1247470 - Don't try to sign bouncer APK during Android single locale repacks. r?glandium

https://reviewboard.mozilla.org/r/34431/#review31357

::: toolkit/mozapps/installer/upload-files.mk:341
(Diff revision 1)
> +INNER_INSTALL_BOUNCER_PACKAGE=echo

If you use true instead of echo, you won't add an empty line to the log.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1b59dd35c8f6

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1b59dd35c8f6

Comment 5

[Axel Hecht [:Pike]]

This might be fixed, hard to tell as the l10n nightlies fail to find tooltool.py, filed bug 1248255 on that.