1248255 - [mobile][single][l10n] l10n single-locale repacks can't find tooltool.py

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Axel Hecht [:Pike]]

Last successful results were at https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=4295f9951e93.

Then bug 1247470 happened, and now that that's fixed, the builds fail with missing tooltool.py in https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=e355cacefc88

Comment 1

[Justin Wood (:Callek)]

Since its tier2, I'm not going to spend too much effort atm, but:

https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/configs/b2g/desktop_linux32.py#38 -- you should specify mock_files for tooltool, and then point at /builds/tooltool.py instead.

Comment 2

[Justin Wood (:Callek)]

O, also mock_files for relengapi.tok (since that's also necessary for any private binaries) https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/tooltool.py#30

Comment 3

[Axel Hecht [:Pike]]

Drilled it down further, https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ac39fba33c6d&tochange=d4d72e7b30da, as the tooltool.py error occurs before the apk one, this was actually in the logs. Just didn't look at the logs beyond their redness for a while.

In those two pushes, there's bug 1242641 with quite a few changes to mock files?

Didn't do an extensive research, though.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

This is about android, so tier 1. Bug 1242641 swapped us to running tooltool inside mock, but we're not copying in the script or token. I'll work up a patch.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [gecko] Update mock_files

Makes sure we have .hgrc, relengapi.tok, tooltool.py, and hgext in any config in testing/mozconfig/config that defines a mock_target. Also removes old configuration files for the single arm build on android.

This would land on inbound and not be uplifted, riding with the changes from bug 1242641.

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 8719645 [details] [diff] [review]
[gecko] Update mock_files

Review of attachment 8719645 [details] [diff] [review]:
-----------------------------------------------------------------

I admittedly didn't confirm the removed files are indeed obsolete, but I think we'd know pretty soon if they are not (and besides -- this is mercurial, we can always backout to restore the files.)

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8719645 [details] [diff] [review]
[gecko] Update mock_files

https://hg.mozilla.org/integration/mozilla-inbound/rev/47d62269142c

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

FTR, I checked some logs for single locale l10n logs for m-c and m-a to determine which configs are in use. The multilocale part of the main build doesn't do any mock.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/47d62269142c

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

The jobs are still failing because we define
    "exes": {
        'tooltool.py': '/tools/tooltool.py',
    },
and copy the file to /builds/tooltool.py.

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [gecko] Fix up exe definition for tooltool.py

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8720558 [details] [diff] [review]
[gecko] Fix up exe definition for tooltool.py

https://hg.mozilla.org/integration/mozilla-inbound/rev/536d8142d8dd

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/536d8142d8dd

Comment 14

[Axel Hecht [:Pike]]

Nick, looking at https://treeherder.mozilla.org/#/jobs?repo=mozilla-aurora&filter-job_group_symbol=L10n&filter-job_group_symbol=Update-3&filter-job_group_symbol=Update-1&filter-job_group_symbol=Update-2&exclusion_profile=false&selectedJob=2040829, this needs uplift to aurora?

Comment 15

[Axel Hecht [:Pike]]

Seems good now by fixes from other bugs.

Comment 16

[Nick Thomas [:nthomas] (UTC+12)]

It was uplifted with the last merge, and beta was taken care of by http://hg.mozilla.org/releases/mozilla-beta/rev/89effb961712. Bug 1262000 will take care of release.