1247653 - TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/testBasicFunctionality.js | testBasicFunctionality.js::testSmokeTest

Status: RESOLVED FIXED

(Calendar :: Provider: GData, defect)

Description

[aleth [:aleth]]

INFO -  SUMMARY-UNEXPECTED-FAIL | testBasicFunctionality.js | testBasicFunctionality.js::testSmokeTest
 05:18:14     INFO -    EXCEPTION: missing ] after element list
 05:18:14     INFO -      at: gdata-calendar-creation.js line 126

Comment 1

[aleth [:aleth]]

Attachment: Replace array comprehension in gdata-calendar-creation.js

Comment 2

[Stefan Sitter [:ssitter]]

Out of curiosity: Is this a recent regression? Linux x64 opt, OS X 10.10 opt from 11-Feb and Windows from 10-Feb ago don't show this Mozmill failure. Or do they not execute the Calendar tests?

Comment 3

[aleth [:aleth]]

(In reply to Stefan Sitter from comment #2)
> Out of curiosity: Is this a recent regression? Linux x64 opt, OS X 10.10 opt
> from 11-Feb and Windows from 10-Feb ago don't show this Mozmill failure. Or
> do they not execute the Calendar tests?

It appears to be Linux32 only (and that was busted until today). Why it's Linux32-only is an interesting question -  I don't know this code and haven't looked into it.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8718393 [details] [diff] [review]
Replace array comprehension in gdata-calendar-creation.js

Review of attachment 8718393 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with a traditional function:

::: calendar/providers/gdata/content/gdata-calendar-creation.js
@@ +122,5 @@
>          let sessionContainer = document.getElementById("gdata-session-group");
>          let newSessionItem = document.getElementById("session-new");
>          let calendars = cal.getCalendarManager().getCalendars({});
> +        let sessions =
> +          new Set(calendars.map(calendar => sessionMgr.getSessionByCalendar(calendar, true)));

Unfortunately can't do arrow functions in gecko 8. Set is shimmed, but arrow functions are syntax.

Comment 5

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/23691a4045a6

Comment 6

[aleth [:aleth]]

Comment on attachment 8718393 [details] [diff] [review]
Replace array comprehension in gdata-calendar-creation.js

Needs uplift to match the dependent bug.

Comment 7

[aleth [:aleth]]

https://hg.mozilla.org/releases/comm-aurora/rev/d79fb6f7dc0f5e5d3b2aa6ec57dc006bbcbd8e7d
Bug 1247653 - Replace array comprehension in gdata-calendar-creation.js. r=Fallen a=Fallen