1247897 - <input> fields are too long with Fx46 (fine in Fx44)

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jens]

Attachment: Input_too_long_Fx_46.png

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:46.0) Gecko/20100101 /
Build ID: 20160211075904

Steps to reproduce:

Go to https://webmail.gandi.net/ using Fx Dev Edition 46.0a2 (2016-02-11)


Actual results:

The input fields are too long and stretch over the form box, see screenshot


Expected results:

Should look like in Fx44, where it is fine.

Comment 1

[YF (Yang)]

WFM in Fx45b4, 46.0a2 (2016-02-11) and 47.0a1 (2016-02-10).

Comment 2

[Loic]

WFM, could you test with a fresh profile, please.
https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles

Comment 3

[Jens]

Yes, also happens with a fresh profile. You must set the language dropdown to "German" as seen in the screenshot at https://bug1247897.bmoattachments.org/attachment.cgi?id=8718785

Comment 4

[Pirmin]

I wrote a bug report of the same problem at the same time. I think, i located the problem:
https://bugzilla.mozilla.org/show_bug.cgi?id=1247929

Comment 5

[Loic]

Bug 1247929 has tescase, duped.

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

These are not the same problem.

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

[Tracking Requested - why for this release]: I'm nominating this for tracking, although I think the reasons that Firefox ends up having overlap and other browsers don't may not be strictly related to the regressing change.  I think the change to the intrinsic widths of the form controls changed the width distribution within the table.  Then, in turn, the table ended up larger, and the controls ended up overlapping the right edge of their cells -- although I believe the controls actually overlap the edge of the cells across browsers, it's just that the table doesn't touch the edge of *its* container across browsers.

I'll try to investigate further next week.  However, it's possible that the least risky course here may be to ship with the regression.

Comment 8

[Loic]

Attachment: index.html (reduced testcase)

The issue is between the width of the <div> and the width (in %) of elements inside the <div> like <input> and <select>.

On the website, the contents of <label> elements (username/password/language) change dynamically according to the language selected in the <select> (the page is refreshed). So when the contents are large, elements <input> and <select> are shifted to the right. But due to the bug, they don't stay in the <div> container (cf. testcase).

Comment 9

[Liz Henry (:lizzard)]

Tracking, recent regression.

Comment 10

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

This is fixed by the patches I will attach to bug 1247929.

Note that the bug is actually related to the <select>, not to the <input>s.

Comment 11

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fixed by bug 1247929.

Comment 12

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fixed for 46 by landing of bug 1247929 on mozilla-aurora (bug 1247929 comment 25).