1248148 - Setting an element to contentEditable=true triggers a selectionchange (it shouldn't)

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[cyril.auburtin]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160212030242

Steps to reproduce:

demo: http://jsfiddle.net/crl/agv7ch2n/



Actual results:

event fired after setting contentEditable to true

if the property is already true no event is fired


Expected results:

no events should be fired when changing that property

Comment 1

[cyril.auburtin]

*no selection event I mean

Comment 2

[Loic]

Attachment: 1248148.html

Comment 3

[Loic]

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=cd8b8017370cf14c472c107d256bb98ce7a19270&tochange=8853d35b1154f25259240308b83ae8d05359ab98

Michael Layzell — Bug 1196479 - Fire selectstart and selectionchange events on the input node when the selection in that editor changes. r=ehsan

Michael, your opinion? Is it expected?

Comment 4

[Nika Layzell [:nika] (ni? for response)]

I don't think that this is expected, but I don't have the time to figure out why it happens right now.

Comment 5

[(no longer active)]

Attachment: Disable firing selection events during HTML editor initialization

This is similar to what we do for the plaintext editor initialization.

Comment 6

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8800672 [details] [diff] [review]
Disable firing selection events during HTML editor initialization

Review of attachment 8800672 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/67300cfca733
Disable firing selection events during HTML editor initialization; r=mystor

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/67300cfca733